ath9k: add support for endian swap of eeprom from platform data
authorFelix Fietkau <nbd@openwrt.org>
Sat, 25 Oct 2014 15:19:33 +0000 (17:19 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 27 Oct 2014 18:16:19 +0000 (14:16 -0400)
On some devices (especially little-endian ones), the flash EEPROM data
has a different endian, which needs to be detected.
Add a flag to the platform data to allow overriding that behavior

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath9k/eeprom_def.c
drivers/net/wireless/ath/ath9k/hw.h
drivers/net/wireless/ath/ath9k/init.c
include/linux/ath9k_platform.h

index 3218ca9947463a844ed38f22956faedaca688cbb..122b846b8ec0e796bed2e15f8a6dc4341b9c00bc 100644 (file)
@@ -262,7 +262,7 @@ static int ath9k_hw_def_check_eeprom(struct ath_hw *ah)
 {
        struct ar5416_eeprom_def *eep = &ah->eeprom.def;
        struct ath_common *common = ath9k_hw_common(ah);
-       u16 *eepdata, temp, magic, magic2;
+       u16 *eepdata, temp, magic;
        u32 sum = 0, el;
        bool need_swap = false;
        int i, addr, size;
@@ -272,27 +272,16 @@ static int ath9k_hw_def_check_eeprom(struct ath_hw *ah)
                return false;
        }
 
-       if (!ath9k_hw_use_flash(ah)) {
-               ath_dbg(common, EEPROM, "Read Magic = 0x%04X\n", magic);
-
-               if (magic != AR5416_EEPROM_MAGIC) {
-                       magic2 = swab16(magic);
-
-                       if (magic2 == AR5416_EEPROM_MAGIC) {
-                               size = sizeof(struct ar5416_eeprom_def);
-                               need_swap = true;
-                               eepdata = (u16 *) (&ah->eeprom);
+       if (swab16(magic) == AR5416_EEPROM_MAGIC &&
+           !(ah->ah_flags & AH_NO_EEP_SWAP)) {
+               size = sizeof(struct ar5416_eeprom_def);
+               need_swap = true;
+               eepdata = (u16 *) (&ah->eeprom);
 
-                               for (addr = 0; addr < size / sizeof(u16); addr++) {
-                                       temp = swab16(*eepdata);
-                                       *eepdata = temp;
-                                       eepdata++;
-                               }
-                       } else {
-                               ath_err(common,
-                                       "Invalid EEPROM Magic. Endianness mismatch.\n");
-                               return -EINVAL;
-                       }
+               for (addr = 0; addr < size / sizeof(u16); addr++) {
+                       temp = swab16(*eepdata);
+                       *eepdata = temp;
+                       eepdata++;
                }
        }
 
index f204099c38b822137c45b79b9880237bbce7420d..c6dba9b4afdf8157fb0f79b020f0d51560a7333d 100644 (file)
@@ -731,6 +731,7 @@ enum ath_cal_list {
 #define AH_USE_EEPROM   0x1
 #define AH_UNPLUGGED    0x2 /* The card has been physically removed. */
 #define AH_FASTCC       0x4
+#define AH_NO_EEP_SWAP  0x8 /* Do not swap EEPROM data */
 
 struct ath_hw {
        struct ath_ops reg_ops;
index 57a17601b0b6bf700ae51a36de169690a774739b..5d9c711b6aa052dddc05273abc915f497f3b2573 100644 (file)
@@ -531,6 +531,8 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc,
                ah->is_clk_25mhz = pdata->is_clk_25mhz;
                ah->get_mac_revision = pdata->get_mac_revision;
                ah->external_reset = pdata->external_reset;
+               if (!pdata->endian_check)
+                       ah->ah_flags |= AH_NO_EEP_SWAP;
        }
 
        common->ops = &ah->reg_ops;
index a495a959e8a754939b9c8c9d9bd748a73f54f587..43501657bce9a8288f6941cc6f1829b67d04f86d 100644 (file)
@@ -31,6 +31,7 @@ struct ath9k_platform_data {
        u32 gpio_mask;
        u32 gpio_val;
 
+       bool endian_check;
        bool is_clk_25mhz;
        bool tx_gain_buffalo;