drm/amd/display: clean up a condition in dmub_psr_copy_settings()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 12 Mar 2020 11:32:31 +0000 (14:32 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 13 Mar 2020 15:52:35 +0000 (11:52 -0400)
We can remove the NULL check for "res_ctx" and
"res_ctx->pipe_ctx[i].stream->link".  Also it's nicer to align the
conditions using spaces so I re-indented a bit.

Longer explanation: The "res_ctx" pointer points to an address in the
middle of a struct so it can't be NULL.  For
"res_ctx->pipe_ctx[i].stream->link" we know that it is equal to "link"
and "link" is non-NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c

index 9c88a92bd96a1ad205cc71f72ee8773343b758d1..bc109d4fc6e6bfcbed02821c0d2b93b4e5aaee77 100644 (file)
@@ -134,11 +134,9 @@ static bool dmub_psr_copy_settings(struct dmub_psr *dmub,
        int i = 0;
 
        for (i = 0; i < MAX_PIPES; i++) {
-               if (res_ctx &&
-                       res_ctx->pipe_ctx[i].stream &&
-                       res_ctx->pipe_ctx[i].stream->link &&
-                       res_ctx->pipe_ctx[i].stream->link == link &&
-                       res_ctx->pipe_ctx[i].stream->link->connector_signal == SIGNAL_TYPE_EDP) {
+               if (res_ctx->pipe_ctx[i].stream &&
+                   res_ctx->pipe_ctx[i].stream->link == link &&
+                   res_ctx->pipe_ctx[i].stream->link->connector_signal == SIGNAL_TYPE_EDP) {
                        pipe_ctx = &res_ctx->pipe_ctx[i];
                        break;
                }