lib/test_bitmap: add testcases for bitmap_parselist()

Add tests for non-number character, empty regions, integer overflow.

[ynorov@marvell.com: v5]
Link: http://lkml.kernel.org/r/20190416063801.20134-5-ynorov@marvell.com
Link: http://lkml.kernel.org/r/20190405173211.11373-5-ynorov@marvell.com
Signed-off-by: Yury Norov <ynorov@marvell.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Kees Cook <keescook@chromium.org>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Mike Travis <travis@sgi.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index 63d4a21955f058a8c6bf79b79623362b10c20311..6640a82ad44b7df6f41c8f5ecb8e1c11a3b8f79d 100644 (file)
--- a/lib/test_bitmap.c
+++ b/lib/test_bitmap.c
@@ -226,7 +226,8 @@ static const unsigned long exp[] __initconst = {
        BITMAP_FROM_U64(0xffffffff),
        BITMAP_FROM_U64(0xfffffffe),
        BITMAP_FROM_U64(0x3333333311111111ULL),
-       BITMAP_FROM_U64(0xffffffff77777777ULL)
+       BITMAP_FROM_U64(0xffffffff77777777ULL),
+       BITMAP_FROM_U64(0),
 };
 
 static const unsigned long exp2[] __initconst = {
@@ -249,19 +250,34 @@ static const struct test_bitmap_parselist parselist_tests[] __initconst = {
        {0, "1-31:4/4",                 &exp[9 * step], 32, 0},
        {0, "0-31:1/4,32-63:2/4",       &exp[10 * step], 64, 0},
        {0, "0-31:3/4,32-63:4/4",       &exp[11 * step], 64, 0},
+       {0, "  ,,  0-31:3/4  ,, 32-63:4/4  ,,  ",       &exp[11 * step], 64, 0},
 
        {0, "0-31:1/4,32-63:2/4,64-95:3/4,96-127:4/4",  exp2, 128, 0},
 
        {0, "0-2047:128/256", NULL, 2048, PARSE_TIME},
 
+       {0, "",                         &exp[12 * step], 8, 0},
+       {0, "\n",                       &exp[12 * step], 8, 0},
+       {0, ",,  ,,  , ,  ,",           &exp[12 * step], 8, 0},
+       {0, " ,  ,,  , ,   ",           &exp[12 * step], 8, 0},
+       {0, " ,  ,,  , ,   \n",         &exp[12 * step], 8, 0},
+
        {-EINVAL, "-1", NULL, 8, 0},
        {-EINVAL, "-0", NULL, 8, 0},
        {-EINVAL, "10-1", NULL, 8, 0},
        {-EINVAL, "0-31:", NULL, 8, 0},
        {-EINVAL, "0-31:0", NULL, 8, 0},
+       {-EINVAL, "0-31:0/", NULL, 8, 0},
        {-EINVAL, "0-31:0/0", NULL, 8, 0},
        {-EINVAL, "0-31:1/0", NULL, 8, 0},
        {-EINVAL, "0-31:10/1", NULL, 8, 0},
+       {-EOVERFLOW, "0-98765432123456789:10/1", NULL, 8, 0},
+
+       {-EINVAL, "a-31", NULL, 8, 0},
+       {-EINVAL, "0-a1", NULL, 8, 0},
+       {-EINVAL, "a-31:10/1", NULL, 8, 0},
+       {-EINVAL, "0-31:a/1", NULL, 8, 0},
+       {-EINVAL, "0-\n", NULL, 8, 0},
 };
 
 static void __init test_bitmap_parselist(void)