efi/bgrt: Drop BGRT status field reserved bits check
authorHans de Goede <hdegoede@redhat.com>
Wed, 29 May 2019 13:28:28 +0000 (15:28 +0200)
committerArd Biesheuvel <ard.biesheuvel@linaro.org>
Tue, 11 Jun 2019 14:13:05 +0000 (16:13 +0200)
Starting with ACPI 6.2 bits 1 and 2 of the BGRT status field are no longer
reserved. These bits are now used to indicate if the image needs to be
rotated before being displayed.

The first device using these bits has now shown up (the GPD MicroPC) and
the reserved bits check causes us to reject the valid BGRT table on this
device.

Rather then changing the reserved bits check, allowing only the 2 new bits,
instead just completely remove it so that we do not end up with a similar
problem when more bits are added in the future.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
drivers/firmware/efi/efi-bgrt.c

index a2384184a7dedf452146d96d3706ce99d90c55b8..b07c17643210ce93746801c5908c02be0ceeb7d3 100644 (file)
@@ -47,11 +47,6 @@ void __init efi_bgrt_init(struct acpi_table_header *table)
                       bgrt->version);
                goto out;
        }
-       if (bgrt->status & 0xfe) {
-               pr_notice("Ignoring BGRT: reserved status bits are non-zero %u\n",
-                      bgrt->status);
-               goto out;
-       }
        if (bgrt->image_type != 0) {
                pr_notice("Ignoring BGRT: invalid image type %u (expected 0)\n",
                       bgrt->image_type);