ocfs2: log valid inode # on bad inode
authorMark Fasheh <mfasheh@ca-build8.us.oracle.com>
Tue, 20 Nov 2007 02:40:16 +0000 (18:40 -0800)
committerMark Fasheh <mark.fasheh@oracle.com>
Wed, 28 Nov 2007 00:47:02 +0000 (16:47 -0800)
If the inode block isn't valid then we don't want to print the value from
that, instead print the block number which was passed in (which should
always be correct). Also, turn this into a debug print for now - folks who
hit an actual problem always have other logs indicating what the source is.

Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
fs/ocfs2/inode.c

index 9e3e7df02c7ae226963341b4813b366fa07a7d98..ebb2bbe30f358b9384662ee0f3d182a74db83c66 100644 (file)
@@ -455,8 +455,8 @@ static int ocfs2_read_locked_inode(struct inode *inode,
        status = -EINVAL;
        fe = (struct ocfs2_dinode *) bh->b_data;
        if (!OCFS2_IS_VALID_DINODE(fe)) {
-               mlog(ML_ERROR, "Invalid dinode #%llu: signature = %.*s\n",
-                    (unsigned long long)le64_to_cpu(fe->i_blkno), 7,
+               mlog(0, "Invalid dinode #%llu: signature = %.*s\n",
+                    (unsigned long long)args->fi_blkno, 7,
                     fe->i_signature);
                goto bail;
        }