USB: usb_wwan: remove unimplemented set_termios
authorJohan Hovold <jhovold@gmail.com>
Mon, 26 May 2014 17:23:22 +0000 (19:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 May 2014 22:04:07 +0000 (15:04 -0700)
The driver does not implement set_termios so the operation can be left
unset (tty will do the tty_termios_copy_hw for us).

Note that the send_setup call is bogus as it really only sets DTR/RTS
to their current values.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/option.c
drivers/usb/serial/usb-wwan.h
drivers/usb/serial/usb_wwan.c

index df91ea9243dfc5e48f398a1406db6c1c12a8311e..51e30740b2fefa43c940d63ab362b4aba7792b47 100644 (file)
@@ -1729,7 +1729,6 @@ static struct usb_serial_driver option_1port_device = {
        .write             = usb_wwan_write,
        .write_room        = usb_wwan_write_room,
        .chars_in_buffer   = usb_wwan_chars_in_buffer,
-       .set_termios       = usb_wwan_set_termios,
        .tiocmget          = usb_wwan_tiocmget,
        .tiocmset          = usb_wwan_tiocmset,
        .ioctl             = usb_wwan_ioctl,
index aca45efbd6749a6c92c34e1fdf820b345def3f5b..dc379603c4b82b65beb8e5811b44a1e566199846 100644 (file)
@@ -11,9 +11,6 @@ extern void usb_wwan_close(struct usb_serial_port *port);
 extern int usb_wwan_port_probe(struct usb_serial_port *port);
 extern int usb_wwan_port_remove(struct usb_serial_port *port);
 extern int usb_wwan_write_room(struct tty_struct *tty);
-extern void usb_wwan_set_termios(struct tty_struct *tty,
-                                struct usb_serial_port *port,
-                                struct ktermios *old);
 extern int usb_wwan_tiocmget(struct tty_struct *tty);
 extern int usb_wwan_tiocmset(struct tty_struct *tty,
                             unsigned int set, unsigned int clear);
index 9aeaccfd4f7436fcbbc4a87815eec866d699b159..aa45985520f725e0a97740d2afcd32892c32fa5c 100644 (file)
@@ -55,20 +55,6 @@ void usb_wwan_dtr_rts(struct usb_serial_port *port, int on)
 }
 EXPORT_SYMBOL(usb_wwan_dtr_rts);
 
-void usb_wwan_set_termios(struct tty_struct *tty,
-                         struct usb_serial_port *port,
-                         struct ktermios *old_termios)
-{
-       struct usb_wwan_intf_private *intfdata = port->serial->private;
-
-       /* Doesn't support option setting */
-       tty_termios_copy_hw(&tty->termios, old_termios);
-
-       if (intfdata->send_setup)
-               intfdata->send_setup(port);
-}
-EXPORT_SYMBOL(usb_wwan_set_termios);
-
 int usb_wwan_tiocmget(struct tty_struct *tty)
 {
        struct usb_serial_port *port = tty->driver_data;