Staging: Android: logger: module_exit implementation
authorLuca Clementi <luca.clementi@gmail.com>
Thu, 22 Nov 2012 03:43:17 +0000 (19:43 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Nov 2012 00:01:30 +0000 (16:01 -0800)
This patch creates the module_exit for the android logger
so that it can be loaded and unloaded as a module.

The android logger is already declared as a tristate in the
Kconfig but the module_exit function was missing.

device_initcall works also with modprobe since include/linux/init.h:

 #define module_init(x)  __initcall(x);
 ...
 #define __initcall(fn) device_initcall(fn)

Tested against f4a75d2eb7b1e2206094b901be09adb31ba63681 Linux 3.7-rc6

Signed-off-by: Luca Clementi <luca.clementi@gmail.com>
Cc: Brian Swetland <swetland@google.com>
Cc: Robert Love <rlove@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/logger.c

index 1d5ed475364b34541c513e7dccb5eaa66cfeeeb4..dbc63cbb4d3a2394a4132874dc3d1f5f5ec46444 100644 (file)
@@ -676,4 +676,25 @@ static int __init logger_init(void)
 out:
        return ret;
 }
+
+static void __exit logger_exit(void)
+{
+       struct logger_log *current_log, *next_log;
+
+       list_for_each_entry_safe(current_log, next_log, &log_list, logs) {
+               /* we have to delete all the entry inside log_list */
+               misc_deregister(&current_log->misc);
+               vfree(current_log->buffer);
+               kfree(current_log->misc.name);
+               list_del(&current_log->logs);
+               kfree(current_log);
+       }
+}
+
+
 device_initcall(logger_init);
+module_exit(logger_exit);
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Robert Love, <rlove@google.com>");
+MODULE_DESCRIPTION("Android Logger");