rtc: cmos: clean up cmos_nvram_read()/cmos_nvram_write()
authorVladimir Zapolskiy <vz@mleia.com>
Sun, 26 Jul 2015 21:48:26 +0000 (00:48 +0300)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Sat, 5 Sep 2015 11:19:09 +0000 (13:19 +0200)
The change removes redundant sysfs binary file boundary checks, since
this task is already done on caller side in fs/sysfs/file.c

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-cmos.c

index c2e90c62a59cab116f0ed43be6bb9c75338e7a55..8f7034ba7d9e30e5ef929ab0362186df249ed3be 100644 (file)
@@ -467,13 +467,6 @@ cmos_nvram_read(struct file *filp, struct kobject *kobj,
 {
        int     retval;
 
-       if (unlikely(off >= attr->size))
-               return 0;
-       if (unlikely(off < 0))
-               return -EINVAL;
-       if ((off + count) > attr->size)
-               count = attr->size - off;
-
        off += NVRAM_OFFSET;
        spin_lock_irq(&rtc_lock);
        for (retval = 0; count; count--, off++, retval++) {
@@ -498,12 +491,6 @@ cmos_nvram_write(struct file *filp, struct kobject *kobj,
        int             retval;
 
        cmos = dev_get_drvdata(container_of(kobj, struct device, kobj));
-       if (unlikely(off >= attr->size))
-               return -EFBIG;
-       if (unlikely(off < 0))
-               return -EINVAL;
-       if ((off + count) > attr->size)
-               count = attr->size - off;
 
        /* NOTE:  on at least PCs and Ataris, the boot firmware uses a
         * checksum on part of the NVRAM data.  That's currently ignored