drm/i915: Be more informative when reporting "too large for aperture" error
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 21 May 2013 15:58:49 +0000 (16:58 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 23 May 2013 10:51:29 +0000 (12:51 +0200)
This should help debugging the truly unexpected cases where it occurs -
in particular to see which value is garbage.

References: https://bugzilla.kernel.org/show_bug.cgi?id=58511
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
[danvet: s/%ld/%zd/ as spotted by Wu Fengguang's autobuilder.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem.c

index a1a282ce2466b883fb7744da4c51dc2484cf7c69..39a9828cdff9f96b6136da3c64af0b3700038f48 100644 (file)
@@ -2975,7 +2975,10 @@ i915_gem_object_bind_to_gtt(struct drm_i915_gem_object *obj,
         */
        if (obj->base.size >
            (map_and_fenceable ? dev_priv->gtt.mappable_end : dev_priv->gtt.total)) {
-               DRM_ERROR("Attempting to bind an object larger than the aperture\n");
+               DRM_ERROR("Attempting to bind an object larger than the aperture: object=%zd > %s aperture=%ld\n",
+                         obj->base.size,
+                         map_and_fenceable ? "mappable" : "total",
+                         map_and_fenceable ? dev_priv->gtt.mappable_end : dev_priv->gtt.total);
                return -E2BIG;
        }