of_mdio: mdio_device_create() never returns NULL
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Sat, 12 Mar 2016 21:33:13 +0000 (00:33 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 19:31:58 +0000 (15:31 -0400)
mdio_device_create() never returns NULL, thus checking for it in
of_mdiobus_register_device() is pointless...

Suggested-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/of/of_mdio.c

index 5e7838290998edb9ec7737b2a6bf2380ebdffbc2..3bc68acac64cf91137a0809764307b2ec9e015f1 100644 (file)
@@ -98,7 +98,7 @@ static int of_mdiobus_register_device(struct mii_bus *mdio,
        int rc;
 
        mdiodev = mdio_device_create(mdio, addr);
-       if (!mdiodev || IS_ERR(mdiodev))
+       if (IS_ERR(mdiodev))
                return 1;
 
        /* Associate the OF node with the device structure so it