net: dsa: lan9303: Fix error return code in lan9303_check_device()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 4 Jan 2018 07:30:28 +0000 (07:30 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Jan 2018 16:24:54 +0000 (11:24 -0500)
Fix to return error code -ENODEV from the chip not found error handling
case instead of 0(ret have been overwritten to 0 by lan9303_read()), as
done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/lan9303-core.c

index 4efb772dbc7e2746fd44e0889be364165b9a0e77..2dead7fa1f93045cf4f40615451ed67d3b5dfd8b 100644 (file)
@@ -865,7 +865,7 @@ static int lan9303_check_device(struct lan9303 *chip)
        if ((reg >> 16) != LAN9303_CHIP_ID) {
                dev_err(chip->dev, "expecting LAN9303 chip, but found: %X\n",
                        reg >> 16);
-               return ret;
+               return -ENODEV;
        }
 
        /* The default state of the LAN9303 device is to forward packets between