tcmu: fix error return code in tcmu_configure_device()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 11 Jan 2018 11:12:25 +0000 (11:12 +0000)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 13 Jan 2018 05:17:35 +0000 (21:17 -0800)
Fix to return error code -ENOMEM from the kzalloc() error handling
case instead of 0, as done elsewhere in this function.

Fixes: 80eb876 ("tcmu: allow max block and global max blocks to be settable")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_user.c

index 1238480cd4c4f29af1427eabc96b5f6bf38c81b5..60c8a87b7a882ae764b5f9d3786da07cf014e1e1 100644 (file)
@@ -1675,8 +1675,10 @@ static int tcmu_configure_device(struct se_device *dev)
 
        udev->data_bitmap = kzalloc(BITS_TO_LONGS(udev->max_blocks) *
                                    sizeof(unsigned long), GFP_KERNEL);
-       if (!udev->data_bitmap)
+       if (!udev->data_bitmap) {
+               ret = -ENOMEM;
                goto err_bitmap_alloc;
+       }
 
        udev->mb_addr = vzalloc(CMDR_SIZE);
        if (!udev->mb_addr) {