fakelb: don't deliver when one phy
authorAlexander Aring <alex.aring@gmail.com>
Sun, 17 May 2015 19:45:01 +0000 (21:45 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Tue, 19 May 2015 09:44:45 +0000 (11:44 +0200)
A real phy don't transmit the transmitted frame back to the phy. This
behaviour will confuse the 6LoWPAN and the upper IPv6 neighbour
discovery cache. We need now at least two virtual phy's to creating a
virtual wpan network.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/net/ieee802154/fakelb.c

index 5c4fbb861eb0461bcc50bacba5a30984f208d93d..d5fb7767834922cf0d3e176cf6561dcb9f26fec6 100644 (file)
@@ -80,20 +80,16 @@ fakelb_hw_xmit(struct ieee802154_hw *hw, struct sk_buff *skb)
 {
        struct fakelb_phy *current_phy = hw->priv;
        struct fakelb_priv *fake = current_phy->fake;
+       struct fakelb_phy *phy;
 
        read_lock_bh(&fake->lock);
-       if (current_phy->list.next == current_phy->list.prev) {
-               /* we are the only one device */
-               fakelb_hw_deliver(current_phy, skb);
-       } else {
-               struct fakelb_phy *phy;
-
-               list_for_each_entry(phy, &current_phy->fake->list, list) {
-                       if (current_phy != phy &&
-                           (phy->hw->phy->current_channel ==
-                            current_phy->hw->phy->current_channel))
-                               fakelb_hw_deliver(phy, skb);
-               }
+       list_for_each_entry(phy, &current_phy->fake->list, list) {
+               if (current_phy == phy)
+                       continue;
+
+               if (phy->hw->phy->current_channel ==
+                   current_phy->hw->phy->current_channel)
+                       fakelb_hw_deliver(phy, skb);
        }
        read_unlock_bh(&fake->lock);