net: hns3: some changes of MSI-X bits in PPU(RCB)
authorWeihang Li <liweihang@hisilicon.com>
Thu, 13 Jun 2019 09:12:25 +0000 (17:12 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 15 Jun 2019 02:26:15 +0000 (19:26 -0700)
This patch modifies print message of rx_q_search_miss from error to dfx to
prevent misleading users, because this interrupt may occur if we receive
packets during initialization of HNS3 driver.
Otherwise, this patch masks 28th bit of PPU_MPF_ABNORMAL_SRC2 which is now
meaningless.

Signed-off-by: Weihang Li <liweihang@hisilicon.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h

index ab9c5d511c7b0e8032b95bb523abe197469932fe..3e0d6ee7eaaa7cc00e2e7f6dc86bf99750d9bb1f 100644 (file)
@@ -1780,9 +1780,8 @@ static int hclge_handle_all_hw_msix_error(struct hclge_dev *hdev,
        status = le32_to_cpu(*(desc_data + 2)) &
                        HCLGE_PPU_MPF_INT_ST2_MSIX_MASK;
        if (status)
-               hclge_log_error(dev, "PPU_MPF_ABNORMAL_INT_ST2",
-                               &hclge_ppu_mpf_abnormal_int_st2[0],
-                               status, reset_requests);
+               dev_warn(dev, "PPU_MPF_ABNORMAL_INT_ST2 rx_q_search_miss found [dfx status=0x%x\n]",
+                        status);
 
        /* clear all main PF MSIx errors */
        ret = hclge_clear_hw_msix_error(hdev, desc, true, mpf_bd_num);
index d821a76db1401aeae4dd058e3a64d3b47f2bed66..db318a4aaf2f89b9538f94f96122b9e6a068d3b2 100644 (file)
@@ -81,7 +81,7 @@
 #define HCLGE_IGU_EGU_TNL_INT_MASK     GENMASK(5, 0)
 #define HCLGE_PPP_MPF_INT_ST3_MASK     GENMASK(5, 0)
 #define HCLGE_PPU_MPF_INT_ST3_MASK     GENMASK(7, 0)
-#define HCLGE_PPU_MPF_INT_ST2_MSIX_MASK        GENMASK(29, 28)
+#define HCLGE_PPU_MPF_INT_ST2_MSIX_MASK        BIT(29)
 #define HCLGE_PPU_PF_INT_RAS_MASK      0x18
 #define HCLGE_PPU_PF_INT_MSIX_MASK     0x26
 #define HCLGE_PPU_PF_OVER_8BD_ERR_MASK 0x01