crypto: ccree - zero out internal struct before use

We did not zero out the internal struct before use causing problem
in some rare error code paths.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/ccree/cc_aead.c b/drivers/crypto/ccree/cc_aead.c
index 16ae6081c4cbbecd6d631f8524bfc5424335e9e6..d9d1c2c1c4d622521316756e92c4f8734b78f1bc 100644 (file)
--- a/drivers/crypto/ccree/cc_aead.c
+++ b/drivers/crypto/ccree/cc_aead.c
@@ -2095,6 +2095,8 @@ static int cc_aead_encrypt(struct aead_request *req)
        struct aead_req_ctx *areq_ctx = aead_request_ctx(req);
        int rc;
 
+       memset(areq_ctx, 0, sizeof(*areq_ctx));
+
        /* No generated IV required */
        areq_ctx->backup_iv = req->iv;
        areq_ctx->backup_giv = NULL;
@@ -2124,6 +2126,8 @@ static int cc_rfc4309_ccm_encrypt(struct aead_request *req)
                goto out;
        }
 
+       memset(areq_ctx, 0, sizeof(*areq_ctx));
+
        /* No generated IV required */
        areq_ctx->backup_iv = req->iv;
        areq_ctx->backup_giv = NULL;
@@ -2143,6 +2147,8 @@ static int cc_aead_decrypt(struct aead_request *req)
        struct aead_req_ctx *areq_ctx = aead_request_ctx(req);
        int rc;
 
+       memset(areq_ctx, 0, sizeof(*areq_ctx));
+
        /* No generated IV required */
        areq_ctx->backup_iv = req->iv;
        areq_ctx->backup_giv = NULL;
@@ -2170,6 +2176,8 @@ static int cc_rfc4309_ccm_decrypt(struct aead_request *req)
                goto out;
        }
 
+       memset(areq_ctx, 0, sizeof(*areq_ctx));
+
        /* No generated IV required */
        areq_ctx->backup_iv = req->iv;
        areq_ctx->backup_giv = NULL;
@@ -2287,6 +2295,8 @@ static int cc_rfc4106_gcm_encrypt(struct aead_request *req)
                goto out;
        }
 
+       memset(areq_ctx, 0, sizeof(*areq_ctx));
+
        /* No generated IV required */
        areq_ctx->backup_iv = req->iv;
        areq_ctx->backup_giv = NULL;
@@ -2310,6 +2320,8 @@ static int cc_rfc4543_gcm_encrypt(struct aead_request *req)
        struct aead_req_ctx *areq_ctx = aead_request_ctx(req);
        int rc;
 
+       memset(areq_ctx, 0, sizeof(*areq_ctx));
+
        //plaintext is not encryped with rfc4543
        areq_ctx->plaintext_authenticate_only = true;
 
@@ -2342,6 +2354,8 @@ static int cc_rfc4106_gcm_decrypt(struct aead_request *req)
                goto out;
        }
 
+       memset(areq_ctx, 0, sizeof(*areq_ctx));
+
        /* No generated IV required */
        areq_ctx->backup_iv = req->iv;
        areq_ctx->backup_giv = NULL;
@@ -2365,6 +2379,8 @@ static int cc_rfc4543_gcm_decrypt(struct aead_request *req)
        struct aead_req_ctx *areq_ctx = aead_request_ctx(req);
        int rc;
 
+       memset(areq_ctx, 0, sizeof(*areq_ctx));
+
        //plaintext is not decryped with rfc4543
        areq_ctx->plaintext_authenticate_only = true;