PCI: Remove pcibios_add_platform_entries()
authorSebastian Ott <sebott@linux.vnet.ibm.com>
Thu, 17 Apr 2014 17:48:07 +0000 (19:48 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 22 May 2014 16:54:07 +0000 (10:54 -0600)
Remove pcibios_add_platform_entries().  Architecture-specific attributes
can be achieved by setting pdev->dev.groups.

Link: https://lkml.kernel.org/r/alpine.LFD.2.11.1404141101500.1529@denkbrett
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/pci-sysfs.c
include/linux/pci.h

index 3db1c7ff5dd38e9c52b4da69fe82d85b949f3c76..b7333fa5f80d3d88ec419319a7431f44cf0aed0a 100644 (file)
@@ -1273,11 +1273,6 @@ static struct bin_attribute pcie_config_attr = {
        .write = pci_write_config,
 };
 
-int __weak pcibios_add_platform_entries(struct pci_dev *dev)
-{
-       return 0;
-}
-
 static ssize_t reset_store(struct device *dev,
                           struct device_attribute *attr, const char *buf,
                           size_t count)
@@ -1393,11 +1388,6 @@ int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev)
                pdev->rom_attr = attr;
        }
 
-       /* add platform-specific attributes */
-       retval = pcibios_add_platform_entries(pdev);
-       if (retval)
-               goto err_rom_file;
-
        /* add sysfs entries for various capabilities */
        retval = pci_create_capabilities_sysfs(pdev);
        if (retval)
index a95aac7ad37fd5100b3407dd79ee633a6f3a5b08..84182b153b21e6916d3cf4070b54de438ab916d1 100644 (file)
@@ -1572,7 +1572,6 @@ extern unsigned long pci_hotplug_io_size;
 extern unsigned long pci_hotplug_mem_size;
 
 /* Architecture-specific versions may override these (weak) */
-int pcibios_add_platform_entries(struct pci_dev *dev);
 void pcibios_disable_device(struct pci_dev *dev);
 void pcibios_set_master(struct pci_dev *dev);
 int pcibios_set_pcie_reset_state(struct pci_dev *dev,