ASoC: sun4i-i2s: Use the actual format width instead of an hardcoded one
authorMaxime Ripard <maxime.ripard@bootlin.com>
Wed, 21 Aug 2019 13:06:54 +0000 (15:06 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 21 Aug 2019 13:16:02 +0000 (14:16 +0100)
The LRCK period field in the FMT0 register holds the number of LRCK period
for one channel in I2S mode.

This has been hardcoded to 32, while it really should be the physical width
of the format, which creates an improper clock when using a 16bit format,
with the i2s controller as LRCK master.

Fixes: 7d2993811a1e ("ASoC: sun4i-i2s: Add support for H3")
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://lore.kernel.org/r/f08a0c3605cd1d79752b38d704690190183f7865.1566392800.git-series.maxime.ripard@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sunxi/sun4i-i2s.c

index cdc3fa60ff33a5fd9796d1c5f423600632c58f7e..9ef784b8867c1c7088834e74c263186a9695d102 100644 (file)
@@ -359,7 +359,7 @@ static int sun4i_i2s_set_clk_rate(struct snd_soc_dai *dai,
        if (i2s->variant->has_fmt_set_lrck_period)
                regmap_update_bits(i2s->regmap, SUN4I_I2S_FMT0_REG,
                                   SUN8I_I2S_FMT0_LRCK_PERIOD_MASK,
-                                  SUN8I_I2S_FMT0_LRCK_PERIOD(32));
+                                  SUN8I_I2S_FMT0_LRCK_PERIOD(slot_width));
 
        return 0;
 }