cxgb4: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

If a debugfs call fails, it will properly warn in the syslog, there's no
need for all individual drivers to also print a message, so that is one
more reason to not care about checking the return values.

Cc: Vishal Kulkarni <vishal@chelsio.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Casey Leedom <leedom@chelsio.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
index 02959035ed3f21287a3673f93c55f0e76b549de1..dd99c55d9a88137773da5054d2a7e47ea857316a 100644 (file)
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
@@ -3529,7 +3529,6 @@ int t4_setup_debugfs(struct adapter *adap)
 {
        int i;
        u32 size = 0;
-       struct dentry *de;
 
        static struct t4_debugfs_entry t4_debugfs_files[] = {
                { "cim_la", &cim_la_fops, 0400, 0 },
@@ -3640,8 +3639,8 @@ int t4_setup_debugfs(struct adapter *adap)
                }
        }
 
-       de = debugfs_create_file_size("flash", 0400, adap->debugfs_root, adap,
-                                     &flash_debugfs_fops, adap->params.sf_size);
+       debugfs_create_file_size("flash", 0400, adap->debugfs_root, adap,
+                                &flash_debugfs_fops, adap->params.sf_size);
        debugfs_create_bool("use_backdoor", 0600,
                            adap->debugfs_root, &adap->use_bd);
        debugfs_create_bool("trace_rss", 0600,

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 4311ad9c84b29f8643166f083ac9ddf97f3a1069..71854a19cebef597fdf6289da071813c8bdb72fe 100644 (file)
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -6269,10 +6269,7 @@ static int __init cxgb4_init_module(void)
 {
        int ret;
 
-       /* Debugfs support is optional, just warn if this fails */
        cxgb4_debugfs_root = debugfs_create_dir(KBUILD_MODNAME, NULL);
-       if (!cxgb4_debugfs_root)
-               pr_warn("could not create debugfs entry, continuing\n");
 
        ret = pci_register_driver(&cxgb4_driver);
        if (ret < 0)

diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
index 6d4cf3d0b2f09099048f00c83f10a66e664f8982..f6fc0875d5b0a285cf4dc5695debdf96b3cf2744 100644 (file)
--- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
@@ -2478,11 +2478,10 @@ static int setup_debugfs(struct adapter *adapter)
         * Debugfs support is best effort.
         */
        for (i = 0; i < ARRAY_SIZE(debugfs_files); i++)
-               (void)debugfs_create_file(debugfs_files[i].name,
-                                 debugfs_files[i].mode,
-                                 adapter->debugfs_root,
-                                 (void *)adapter,
-                                 debugfs_files[i].fops);
+               debugfs_create_file(debugfs_files[i].name,
+                                   debugfs_files[i].mode,
+                                   adapter->debugfs_root, (void *)adapter,
+                                   debugfs_files[i].fops);
 
        return 0;
 }
@@ -3257,11 +3256,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
                adapter->debugfs_root =
                        debugfs_create_dir(pci_name(pdev),
                                           cxgb4vf_debugfs_root);
-               if (IS_ERR_OR_NULL(adapter->debugfs_root))
-                       dev_warn(&pdev->dev, "could not create debugfs"
-                                " directory");
-               else
-                       setup_debugfs(adapter);
+               setup_debugfs(adapter);
        }
 
        /*
@@ -3486,13 +3481,11 @@ static int __init cxgb4vf_module_init(void)
                return -EINVAL;
        }
 
-       /* Debugfs support is optional, just warn if this fails */
+       /* Debugfs support is optional, debugfs will warn if this fails */
        cxgb4vf_debugfs_root = debugfs_create_dir(KBUILD_MODNAME, NULL);
-       if (IS_ERR_OR_NULL(cxgb4vf_debugfs_root))
-               pr_warn("could not create debugfs entry, continuing\n");
 
        ret = pci_register_driver(&cxgb4vf_driver);
-       if (ret < 0 && !IS_ERR_OR_NULL(cxgb4vf_debugfs_root))
+       if (ret < 0)
                debugfs_remove(cxgb4vf_debugfs_root);
        return ret;
 }