drm/exynos: remove exynos_plane_commit() wrapper
authorGustavo Padovan <gustavo.padovan@collabora.co.uk>
Fri, 14 Nov 2014 00:17:46 +0000 (22:17 -0200)
committerInki Dae <daeinki@gmail.com>
Sun, 25 Jan 2015 12:28:05 +0000 (21:28 +0900)
It's doing nothing but calling exynos_crtc->ops->win_commit(), so let's
call this directly to avoid extra layers of abstraction.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_crtc.c
drivers/gpu/drm/exynos/exynos_drm_plane.c
drivers/gpu/drm/exynos/exynos_drm_plane.h

index e946b5f5e3ac940fdbd97dce88cedbee5f2f4be6..a43e25d57a02c15f498f4ce36dda0153499be4b1 100644 (file)
@@ -59,10 +59,12 @@ static void exynos_drm_crtc_commit(struct drm_crtc *crtc)
 {
        struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
        struct exynos_drm_manager *manager = exynos_crtc->manager;
+       struct exynos_drm_plane *exynos_plane = to_exynos_plane(crtc->primary);
 
        exynos_drm_crtc_dpms(crtc, DRM_MODE_DPMS_ON);
 
-       exynos_plane_commit(crtc->primary);
+       if (manager->ops->win_commit)
+               manager->ops->win_commit(manager, exynos_plane->zpos);
 
        if (manager->ops->commit)
                manager->ops->commit(manager);
index 4fe3c2b555b13d76ffeca233b8233e34176fb920..aa9cc9a0a033f7acec7e5821c5cb9bfa7e04d6d3 100644 (file)
@@ -139,15 +139,6 @@ int exynos_plane_mode_set(struct drm_plane *plane, struct drm_crtc *crtc,
        return 0;
 }
 
-void exynos_plane_commit(struct drm_plane *plane)
-{
-       struct exynos_drm_plane *exynos_plane = to_exynos_plane(plane);
-       struct exynos_drm_manager *manager = to_exynos_crtc(plane->crtc)->manager;
-
-       if (manager->ops->win_commit)
-               manager->ops->win_commit(manager, exynos_plane->zpos);
-}
-
 void exynos_plane_dpms(struct drm_plane *plane, int mode)
 {
        struct exynos_drm_plane *exynos_plane = to_exynos_plane(plane);
@@ -181,6 +172,9 @@ exynos_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
                     uint32_t src_x, uint32_t src_y,
                     uint32_t src_w, uint32_t src_h)
 {
+
+       struct exynos_drm_manager *manager = to_exynos_crtc(crtc)->manager;
+       struct exynos_drm_plane *exynos_plane = to_exynos_plane(plane);
        int ret;
 
        ret = exynos_plane_mode_set(plane, crtc, fb, crtc_x, crtc_y,
@@ -189,7 +183,8 @@ exynos_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
        if (ret < 0)
                return ret;
 
-       exynos_plane_commit(plane);
+       if (manager->ops->win_commit)
+               manager->ops->win_commit(manager, exynos_plane->zpos);
 
        return 0;
 }
index 0d1986b115f89543fca89953aa04930addabc215..3c239891926ee7211c5333534dbc268affd4f888 100644 (file)
@@ -14,7 +14,6 @@ int exynos_plane_mode_set(struct drm_plane *plane, struct drm_crtc *crtc,
                          unsigned int crtc_w, unsigned int crtc_h,
                          uint32_t src_x, uint32_t src_y,
                          uint32_t src_w, uint32_t src_h);
-void exynos_plane_commit(struct drm_plane *plane);
 void exynos_plane_dpms(struct drm_plane *plane, int mode);
 struct drm_plane *exynos_plane_init(struct drm_device *dev,
                                    unsigned long possible_crtcs,