bcm63xx_enet: use devm_platform_ioremap_resource() to simplify code
authorYueHaibing <yuehaibing@huawei.com>
Thu, 1 Aug 2019 12:39:08 +0000 (20:39 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 1 Aug 2019 17:10:34 +0000 (13:10 -0400)
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bcm63xx_enet.c

index 291e4afd4a1ac535674bdd5839cd702650657efb..620cd3fc1fbcbecdec67dc13fe078bd5be8b9dab 100644 (file)
@@ -1693,7 +1693,7 @@ static int bcm_enet_probe(struct platform_device *pdev)
        struct bcm_enet_priv *priv;
        struct net_device *dev;
        struct bcm63xx_enet_platform_data *pd;
-       struct resource *res_mem, *res_irq, *res_irq_rx, *res_irq_tx;
+       struct resource *res_irq, *res_irq_rx, *res_irq_tx;
        struct mii_bus *bus;
        int i, ret;
 
@@ -1719,8 +1719,7 @@ static int bcm_enet_probe(struct platform_device *pdev)
        if (ret)
                goto out;
 
-       res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       priv->base = devm_ioremap_resource(&pdev->dev, res_mem);
+       priv->base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(priv->base)) {
                ret = PTR_ERR(priv->base);
                goto out;
@@ -2762,15 +2761,13 @@ struct platform_driver bcm63xx_enetsw_driver = {
 /* reserve & remap memory space shared between all macs */
 static int bcm_enet_shared_probe(struct platform_device *pdev)
 {
-       struct resource *res;
        void __iomem *p[3];
        unsigned int i;
 
        memset(bcm_enet_shared_base, 0, sizeof(bcm_enet_shared_base));
 
        for (i = 0; i < 3; i++) {
-               res = platform_get_resource(pdev, IORESOURCE_MEM, i);
-               p[i] = devm_ioremap_resource(&pdev->dev, res);
+               p[i] = devm_platform_ioremap_resource(pdev, i);
                if (IS_ERR(p[i]))
                        return PTR_ERR(p[i]);
        }