umbim: use IP configuration provided by MBIM by default
authorLech Perczak <lech.perczak@gmail.com>
Mon, 19 Jul 2021 17:04:09 +0000 (19:04 +0200)
committerHauke Mehrtens <hauke@hauke-m.de>
Sat, 29 Apr 2023 19:33:04 +0000 (21:33 +0200)
Previously, DHCP was used. According to MBIM Specification v1.0 errata 1 [1],
section 10.5.20, MBIM_CID_IP_CONFIGURATION,
if MBIM information element containing IP configuration is available,
host shall use it, and fall back to in-band mechanisms to acquire it therwise -
therefore make static configuration the default.

[1] https://www.usb.org/document-library/mobile-broadband-interface-model-v10-errata-1-and-adopters-agreement

Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
package/network/utils/umbim/files/lib/netifd/proto/mbim.sh

index c5f3663271082eb18183857b3aacbadbb1f2c14c..3867411818a0f7acd8e9801195f5b39925724dac 100755 (executable)
@@ -169,7 +169,7 @@ _proto_mbim_setup() {
 
        echo "mbim[$$]" "Connected"
 
-       if [ "$dhcp" = 0 ]; then
+       if [ -z "$dhcp" -o "$dhcp" = 0 ]; then
                echo "mbim[$$]" "Setting up $ifname"
                eval $(umbim $DBG -n -t $tid -d $device config | sed 's/: /=/g')
                tid=$((tid + 1))