powerpc/mm: check for irq disabled() only if DEBUG_VM is enabled
authorAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Tue, 26 Jul 2016 22:22:39 +0000 (15:22 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 26 Jul 2016 23:19:19 +0000 (16:19 -0700)
We don't need to check this always.  The idea here is to capture the
wrong usage of find_linux_pte_or_hugepte and we can do that by
occasionally running with DEBUG_VM enabled.

Link: http://lkml.kernel.org/r/1464692688-6612-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/powerpc/include/asm/pgtable.h

index ee09e99097f026ed1a8c3242cf20b447504c109b..9bd87f269d6d78716eb80d1feda42d6c49a9cc60 100644 (file)
@@ -71,10 +71,8 @@ pte_t *__find_linux_pte_or_hugepte(pgd_t *pgdir, unsigned long ea,
 static inline pte_t *find_linux_pte_or_hugepte(pgd_t *pgdir, unsigned long ea,
                                               bool *is_thp, unsigned *shift)
 {
-       if (!arch_irqs_disabled()) {
-               pr_info("%s called with irq enabled\n", __func__);
-               dump_stack();
-       }
+       VM_WARN(!arch_irqs_disabled(),
+               "%s called with irq enabled\n", __func__);
        return __find_linux_pte_or_hugepte(pgdir, ea, is_thp, shift);
 }