enic: unmask intr only when napi is complete
authorGovindarajulu Varadarajan <gvaradar@cisco.com>
Mon, 22 May 2017 19:19:48 +0000 (12:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 May 2017 15:05:45 +0000 (11:05 -0400)
In case of busy poll, napi_complete_done returns false and does not
dequeue napi. In this case do not unmask the intr. We are guaranteed
napi is called again. This reduces unnecessary iowrites.

Signed-off-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cisco/enic/enic_main.c

index 4b87beeabce12a6e55e41c5beb3d3e0a39b6ecea..6a9c8878aca01959f16016e69a9a67476c1b8887 100644 (file)
@@ -1537,13 +1537,12 @@ static int enic_poll(struct napi_struct *napi, int budget)
                 */
                enic_calc_int_moderation(enic, &enic->rq[0]);
 
-       if (rq_work_done < rq_work_to_do) {
+       if ((rq_work_done < budget) && napi_complete_done(napi, rq_work_done)) {
 
                /* Some work done, but not enough to stay in polling,
                 * exit polling
                 */
 
-               napi_complete_done(napi, rq_work_done);
                if (enic->rx_coalesce_setting.use_adaptive_rx_coalesce)
                        enic_set_int_moderation(enic, &enic->rq[0]);
                vnic_intr_unmask(&enic->intr[intr]);
@@ -1663,13 +1662,12 @@ static int enic_poll_msix_rq(struct napi_struct *napi, int budget)
                 */
                enic_calc_int_moderation(enic, &enic->rq[rq]);
 
-       if (work_done < work_to_do) {
+       if ((work_done < budget) && napi_complete_done(napi, work_done)) {
 
                /* Some work done, but not enough to stay in polling,
                 * exit polling
                 */
 
-               napi_complete_done(napi, work_done);
                if (enic->rx_coalesce_setting.use_adaptive_rx_coalesce)
                        enic_set_int_moderation(enic, &enic->rq[rq]);
                vnic_intr_unmask(&enic->intr[intr]);