media: staging: imgu: make imgu work on low frequency for low input
authorBingbu Cao <bingbu.cao@intel.com>
Fri, 16 Aug 2019 10:20:48 +0000 (12:20 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 12 Mar 2020 16:16:55 +0000 (17:16 +0100)
Currently, imgu is working on 450MHz for all cases, however
in some cases (input frame less than 2048x1152), the imgu
did not need work in high frequency.
This patch make imgu work on 200MHz if the imgu input
frame is less than 2048x1152 to save power.

Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/ipu3/ipu3-css.c
drivers/staging/media/ipu3/ipu3-css.h
drivers/staging/media/ipu3/ipu3.c

index f36de501edc6a5d554845ba685b98934aa6325a7..4f04fe838b0c02bddec60d459fac5510b47f582e 100644 (file)
@@ -210,12 +210,12 @@ static int imgu_hw_wait(void __iomem *base, int reg, u32 mask, u32 cmp)
 
 /* Initialize the IPU3 CSS hardware and associated h/w blocks */
 
-int imgu_css_set_powerup(struct device *dev, void __iomem *base)
+int imgu_css_set_powerup(struct device *dev, void __iomem *base,
+                        unsigned int freq)
 {
-       static const unsigned int freq = 450;
        u32 pm_ctrl, state, val;
 
-       dev_dbg(dev, "%s\n", __func__);
+       dev_dbg(dev, "%s with freq %u\n", __func__, freq);
        /* Clear the CSS busy signal */
        readl(base + IMGU_REG_GP_BUSY);
        writel(0, base + IMGU_REG_GP_BUSY);
index 6b8bab27ab1f86a1e34319917593bf2de71077ed..6108a068b228fc709c270436695f6ee1a32d3ec4 100644 (file)
@@ -187,7 +187,8 @@ bool imgu_css_is_streaming(struct imgu_css *css);
 bool imgu_css_pipe_queue_empty(struct imgu_css *css, unsigned int pipe);
 
 /******************* css hw *******************/
-int imgu_css_set_powerup(struct device *dev, void __iomem *base);
+int imgu_css_set_powerup(struct device *dev, void __iomem *base,
+                        unsigned int freq);
 void imgu_css_set_powerdown(struct device *dev, void __iomem *base);
 int imgu_css_irq_ack(struct imgu_css *css);
 
index 06a61f31ca50b2c17fbc5b35a2b8e08c5489627b..4d53aad31483207677552f5606e5020c0fb6e56f 100644 (file)
@@ -345,8 +345,20 @@ failed:
 static int imgu_powerup(struct imgu_device *imgu)
 {
        int r;
+       unsigned int pipe;
+       unsigned int freq = 200;
+       struct v4l2_mbus_framefmt *fmt;
+
+       /* input larger than 2048*1152, ask imgu to work on high freq */
+       for_each_set_bit(pipe, imgu->css.enabled_pipes, IMGU_MAX_PIPE_NUM) {
+               fmt = &imgu->imgu_pipe[pipe].nodes[IMGU_NODE_IN].pad_fmt;
+               dev_dbg(&imgu->pci_dev->dev, "pipe %u input format = %ux%u",
+                       pipe, fmt->width, fmt->height);
+               if ((fmt->width * fmt->height) >= (2048 * 1152))
+                       freq = 450;
+       }
 
-       r = imgu_css_set_powerup(&imgu->pci_dev->dev, imgu->base);
+       r = imgu_css_set_powerup(&imgu->pci_dev->dev, imgu->base, freq);
        if (r)
                return r;
 
@@ -666,7 +678,7 @@ static int imgu_pci_probe(struct pci_dev *pci_dev,
        atomic_set(&imgu->qbuf_barrier, 0);
        init_waitqueue_head(&imgu->buf_drain_wq);
 
-       r = imgu_css_set_powerup(&pci_dev->dev, imgu->base);
+       r = imgu_css_set_powerup(&pci_dev->dev, imgu->base, 200);
        if (r) {
                dev_err(&pci_dev->dev,
                        "failed to power up CSS (%d)\n", r);