staging: lustre: discard libcfs_kvzalloc_cpt()
authorNeilBrown <neilb@suse.com>
Tue, 20 Feb 2018 02:23:37 +0000 (13:23 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Feb 2018 14:03:23 +0000 (15:03 +0100)
This function is used precisely once, and is sufficiently
trivial that it may as well be open-coded.

Doing so helpfully highlights the similarity
between the new kvzalloc_node() call and the already existing
kzalloc_node() call in the same function.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/include/linux/libcfs/libcfs.h
drivers/staging/lustre/lnet/libcfs/linux/linux-mem.c
drivers/staging/lustre/lustre/ptlrpc/service.c

index 4f8c65e6d8834edc82c6345ffaafaa692a4f4d0a..03920576302149b978ef729fb3c9ec6220749919 100644 (file)
@@ -113,8 +113,6 @@ static inline void *__container_of(void *ptr, unsigned long shift)
 #define _LIBCFS_H
 
 void *libcfs_kvzalloc(size_t size, gfp_t flags);
-void *libcfs_kvzalloc_cpt(struct cfs_cpt_table *cptab, int cpt, size_t size,
-                         gfp_t flags);
 
 extern struct miscdevice libcfs_dev;
 /**
index 963df0ef4afb15811fdf96f35919630070d3fa70..f2c001bac30370cc54c96919e1dfdfd067520dd4 100644 (file)
@@ -42,10 +42,3 @@ void *libcfs_kvzalloc(size_t size, gfp_t flags)
        return ret;
 }
 EXPORT_SYMBOL(libcfs_kvzalloc);
-
-void *libcfs_kvzalloc_cpt(struct cfs_cpt_table *cptab, int cpt, size_t size,
-                         gfp_t flags)
-{
-       return kvzalloc_node(size, flags, cfs_cpt_spread_node(cptab, cpt));
-}
-EXPORT_SYMBOL(libcfs_kvzalloc_cpt);
index 29fdb54f16cac51b2db3d4dd2b05f4b728b213e9..57e41e2cd30ae701fe6b5860750ba180b3d442db 100644 (file)
@@ -83,10 +83,10 @@ ptlrpc_alloc_rqbd(struct ptlrpc_service_part *svcpt)
        rqbd->rqbd_cbid.cbid_fn = request_in_callback;
        rqbd->rqbd_cbid.cbid_arg = rqbd;
        INIT_LIST_HEAD(&rqbd->rqbd_reqs);
-       rqbd->rqbd_buffer = libcfs_kvzalloc_cpt(svc->srv_cptable,
-                                               svcpt->scp_cpt,
-                                               svc->srv_buf_size,
-                                               GFP_KERNEL);
+       rqbd->rqbd_buffer = kvzalloc_node(svc->srv_buf_size, GFP_KERNEL,
+                                         cfs_cpt_spread_node(svc->srv_cptable,
+                                                             svcpt->scp_cpt));
+
        if (!rqbd->rqbd_buffer) {
                kfree(rqbd);
                return NULL;