drm: Release resources with a safer function
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 7 Oct 2016 07:27:41 +0000 (09:27 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 10 Oct 2016 09:20:48 +0000 (11:20 +0200)
We should use 'ida_simple_remove()' instead of 'ida_remove()' when freeing
resources allocated with 'ida_simple_get()'.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1475825261-7735-1-git-send-email-christophe.jaillet@wanadoo.fr
drivers/gpu/drm/drm_connector.c

index 2e74302830437ae131079b98d691370bce5d9e82..2db7fb510b6c941c2f252dc29591e4c51cd981c5 100644 (file)
@@ -341,11 +341,11 @@ void drm_connector_cleanup(struct drm_connector *connector)
        list_for_each_entry_safe(mode, t, &connector->modes, head)
                drm_mode_remove(connector, mode);
 
-       ida_remove(&drm_connector_enum_list[connector->connector_type].ida,
-                  connector->connector_type_id);
+       ida_simple_remove(&drm_connector_enum_list[connector->connector_type].ida,
+                         connector->connector_type_id);
 
-       ida_remove(&dev->mode_config.connector_ida,
-                  connector->index);
+       ida_simple_remove(&dev->mode_config.connector_ida,
+                         connector->index);
 
        kfree(connector->display_info.bus_formats);
        drm_mode_object_unregister(dev, &connector->base);