thermal: stm32: Fix stm_thermal_read_factory_settings
authorDavid HERNANDEZ SANCHEZ <david.hernandezsanchez@st.com>
Thu, 6 Dec 2018 13:23:32 +0000 (13:23 +0000)
committerEduardo Valentin <edubezval@gmail.com>
Tue, 11 Dec 2018 04:15:28 +0000 (20:15 -0800)
Adding brackets allows to multiply the register value,
masked by TS1_RAMP_COEFF_MASK, by an ADJUST value
properly and not to multiply ADJUST by register value and
then mask the whole.

Fixes: 1d693155 ("thermal: add stm32 thermal driver")
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: David Hernandez Sanchez <david.hernandezsanchez@st.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/st/stm_thermal.c

index daa1257809a603ed44cdb6057b8293e79e11ec13..bbd73c5a4a4e92f4c3d361f129e7ec7d409a6d94 100644 (file)
@@ -241,8 +241,8 @@ static int stm_thermal_read_factory_settings(struct stm_thermal_sensor *sensor)
                sensor->t0 = TS1_T0_VAL1;
 
        /* Retrieve fmt0 and put it on Hz */
-       sensor->fmt0 = ADJUST * readl_relaxed(sensor->base + DTS_T0VALR1_OFFSET)
-                                             & TS1_FMT0_MASK;
+       sensor->fmt0 = ADJUST * (readl_relaxed(sensor->base +
+                                DTS_T0VALR1_OFFSET) & TS1_FMT0_MASK);
 
        /* Retrieve ramp coefficient */
        sensor->ramp_coeff = readl_relaxed(sensor->base + DTS_RAMPVALR_OFFSET) &