drm/i915: Check for fused or unused pipes
authorMika Kahola <mika.kahola@intel.com>
Mon, 18 Dec 2017 08:04:03 +0000 (10:04 +0200)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 1 Feb 2018 15:32:49 +0000 (07:32 -0800)
We may have fused or unused pipes in our system. Let's check that the pipe
in question is within limits of accessible pipes. In case, that we are not
able to access the pipe, we return early with a warning.

v2: Rephrasing of the commit message (Jani)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206
Reported-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Jaswinder Singh Rajput <jaswinder@perfectintelligent.com>
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1513584243-12607-1-git-send-email-mika.kahola@intel.com
(cherry picked from commit 0b7029b7e43fda1304c181a3ade0b429b9edcd9d)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: <stable@vger.kernel.org> # v4.10+
drivers/gpu/drm/i915/intel_audio.c

index f1502a0188eb23e51a746b4f6bbedaecf3167ad1..522d54fecb53489193eb2b72dbf9fdd41009ac67 100644 (file)
@@ -779,7 +779,7 @@ static struct intel_encoder *get_saved_enc(struct drm_i915_private *dev_priv,
 {
        struct intel_encoder *encoder;
 
-       if (WARN_ON(pipe >= INTEL_INFO(dev_priv)->num_pipes))
+       if (WARN_ON(pipe >= ARRAY_SIZE(dev_priv->av_enc_map)))
                return NULL;
 
        /* MST */