x86: use symbolic name for VM86_SIGNAL when used as vm86 default return
authorSamuel Bronson <naesten@gmail.com>
Thu, 7 May 2009 02:27:55 +0000 (22:27 -0400)
committerH. Peter Anvin <hpa@zytor.com>
Thu, 7 May 2009 03:35:26 +0000 (20:35 -0700)
This code has apparently used "0" and not VM86_SIGNAL since Linux
1.1.9, when Linus added VM86_SIGNAL to vm86.h. This patch changes the
code to use the symbolic name.

The magic 0 tripped me up in trying to extend the vm86(2) manpage to
actually explain vm86()'s interface -- my greps for VM86_SIGNAL came up
fruitless.

[ Impact: cleanup; no object code change ]

Signed-off-by: Samuel Bronson <naesten@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
arch/x86/kernel/vm86_32.c

index d7ac84e7fc1c73f7cfcfd8ca6b66c5abed2219ce..b8035a0f4048abf99174ab8766b4cf6f9b3b521c 100644 (file)
@@ -318,9 +318,9 @@ static void do_sys_vm86(struct kernel_vm86_struct *info, struct task_struct *tsk
        }
 
 /*
- * Save old state, set default return value (%ax) to 0
+ * Save old state, set default return value (%ax) to 0 (VM86_SIGNAL)
  */
-       info->regs32->ax = 0;
+       info->regs32->ax = VM86_SIGNAL;
        tsk->thread.saved_sp0 = tsk->thread.sp0;
        tsk->thread.saved_fs = info->regs32->fs;
        tsk->thread.saved_gs = get_user_gs(info->regs32);