xprtrdma: Remove usage of "mw"
authorChuck Lever <chuck.lever@oracle.com>
Fri, 15 Dec 2017 01:57:55 +0000 (20:57 -0500)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Tue, 16 Jan 2018 16:19:51 +0000 (11:19 -0500)
Clean up: struct rpcrdma_mw was named after Memory Windows, but
xprtrdma no longer supports a Memory Window registration mode.
Rename rpcrdma_mw and its fields to reduce confusion and make
the code more sensible to read.

Renaming "mw" was suggested by Tom Talpey, the author of the
original xprtrdma implementation. It's a good idea, but I haven't
done this until now because it's a huge diffstat for no benefit
other than code readability.

However, I'm about to introduce static trace points that expose
a few of xprtrdma's internal data structures. They should make sense
in the trace report, and it's reasonable to treat trace points as a
kernel API contract which might be difficult to change later.

While I'm churning things up, two additional changes:
- rename variables unhelpfully called "r" to "mr", to improve code
  clarity, and
- rename the MR-related helper functions using the form
  "rpcrdma_mr_<verb>", to be consistent with other areas of the
  code.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
net/sunrpc/xprtrdma/fmr_ops.c
net/sunrpc/xprtrdma/frwr_ops.c
net/sunrpc/xprtrdma/rpc_rdma.c
net/sunrpc/xprtrdma/verbs.c
net/sunrpc/xprtrdma/xprt_rdma.h

index 29fc84c7ff98ff49b272deeb3b1a46759b794ca2..8bd0399b3a1c26abe5f1ca2db4c08093c5070a8a 100644 (file)
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Copyright (c) 2015 Oracle.  All rights reserved.
+ * Copyright (c) 2015, 2017 Oracle.  All rights reserved.
  * Copyright (c) 2003-2007 Network Appliance, Inc. All rights reserved.
  */
 
@@ -47,7 +47,7 @@ fmr_is_supported(struct rpcrdma_ia *ia)
 }
 
 static int
-fmr_op_init_mr(struct rpcrdma_ia *ia, struct rpcrdma_mw *mw)
+fmr_op_init_mr(struct rpcrdma_ia *ia, struct rpcrdma_mr *mr)
 {
        static struct ib_fmr_attr fmr_attr = {
                .max_pages      = RPCRDMA_MAX_FMR_SGES,
@@ -55,106 +55,106 @@ fmr_op_init_mr(struct rpcrdma_ia *ia, struct rpcrdma_mw *mw)
                .page_shift     = PAGE_SHIFT
        };
 
-       mw->fmr.fm_physaddrs = kcalloc(RPCRDMA_MAX_FMR_SGES,
+       mr->fmr.fm_physaddrs = kcalloc(RPCRDMA_MAX_FMR_SGES,
                                       sizeof(u64), GFP_KERNEL);
-       if (!mw->fmr.fm_physaddrs)
+       if (!mr->fmr.fm_physaddrs)
                goto out_free;
 
-       mw->mw_sg = kcalloc(RPCRDMA_MAX_FMR_SGES,
-                           sizeof(*mw->mw_sg), GFP_KERNEL);
-       if (!mw->mw_sg)
+       mr->mr_sg = kcalloc(RPCRDMA_MAX_FMR_SGES,
+                           sizeof(*mr->mr_sg), GFP_KERNEL);
+       if (!mr->mr_sg)
                goto out_free;
 
-       sg_init_table(mw->mw_sg, RPCRDMA_MAX_FMR_SGES);
+       sg_init_table(mr->mr_sg, RPCRDMA_MAX_FMR_SGES);
 
-       mw->fmr.fm_mr = ib_alloc_fmr(ia->ri_pd, RPCRDMA_FMR_ACCESS_FLAGS,
+       mr->fmr.fm_mr = ib_alloc_fmr(ia->ri_pd, RPCRDMA_FMR_ACCESS_FLAGS,
                                     &fmr_attr);
-       if (IS_ERR(mw->fmr.fm_mr))
+       if (IS_ERR(mr->fmr.fm_mr))
                goto out_fmr_err;
 
        return 0;
 
 out_fmr_err:
        dprintk("RPC:       %s: ib_alloc_fmr returned %ld\n", __func__,
-               PTR_ERR(mw->fmr.fm_mr));
+               PTR_ERR(mr->fmr.fm_mr));
 
 out_free:
-       kfree(mw->mw_sg);
-       kfree(mw->fmr.fm_physaddrs);
+       kfree(mr->mr_sg);
+       kfree(mr->fmr.fm_physaddrs);
        return -ENOMEM;
 }
 
 static int
-__fmr_unmap(struct rpcrdma_mw *mw)
+__fmr_unmap(struct rpcrdma_mr *mr)
 {
        LIST_HEAD(l);
        int rc;
 
-       list_add(&mw->fmr.fm_mr->list, &l);
+       list_add(&mr->fmr.fm_mr->list, &l);
        rc = ib_unmap_fmr(&l);
-       list_del(&mw->fmr.fm_mr->list);
+       list_del(&mr->fmr.fm_mr->list);
        return rc;
 }
 
 static void
-fmr_op_release_mr(struct rpcrdma_mw *r)
+fmr_op_release_mr(struct rpcrdma_mr *mr)
 {
        LIST_HEAD(unmap_list);
        int rc;
 
        /* Ensure MW is not on any rl_registered list */
-       if (!list_empty(&r->mw_list))
-               list_del(&r->mw_list);
+       if (!list_empty(&mr->mr_list))
+               list_del(&mr->mr_list);
 
-       kfree(r->fmr.fm_physaddrs);
-       kfree(r->mw_sg);
+       kfree(mr->fmr.fm_physaddrs);
+       kfree(mr->mr_sg);
 
        /* In case this one was left mapped, try to unmap it
         * to prevent dealloc_fmr from failing with EBUSY
         */
-       rc = __fmr_unmap(r);
+       rc = __fmr_unmap(mr);
        if (rc)
                pr_err("rpcrdma: final ib_unmap_fmr for %p failed %i\n",
-                      r, rc);
+                      mr, rc);
 
-       rc = ib_dealloc_fmr(r->fmr.fm_mr);
+       rc = ib_dealloc_fmr(mr->fmr.fm_mr);
        if (rc)
                pr_err("rpcrdma: final ib_dealloc_fmr for %p returned %i\n",
-                      r, rc);
+                      mr, rc);
 
-       kfree(r);
+       kfree(mr);
 }
 
 /* Reset of a single FMR.
  */
 static void
-fmr_op_recover_mr(struct rpcrdma_mw *mw)
+fmr_op_recover_mr(struct rpcrdma_mr *mr)
 {
-       struct rpcrdma_xprt *r_xprt = mw->mw_xprt;
+       struct rpcrdma_xprt *r_xprt = mr->mr_xprt;
        int rc;
 
        /* ORDER: invalidate first */
-       rc = __fmr_unmap(mw);
+       rc = __fmr_unmap(mr);
 
        /* ORDER: then DMA unmap */
        ib_dma_unmap_sg(r_xprt->rx_ia.ri_device,
-                       mw->mw_sg, mw->mw_nents, mw->mw_dir);
+                       mr->mr_sg, mr->mr_nents, mr->mr_dir);
        if (rc)
                goto out_release;
 
-       rpcrdma_put_mw(r_xprt, mw);
+       rpcrdma_mr_put(mr);
        r_xprt->rx_stats.mrs_recovered++;
        return;
 
 out_release:
-       pr_err("rpcrdma: FMR reset failed (%d), %p released\n", rc, mw);
+       pr_err("rpcrdma: FMR reset failed (%d), %p released\n", rc, mr);
        r_xprt->rx_stats.mrs_orphaned++;
 
-       spin_lock(&r_xprt->rx_buf.rb_mwlock);
-       list_del(&mw->mw_all);
-       spin_unlock(&r_xprt->rx_buf.rb_mwlock);
+       spin_lock(&r_xprt->rx_buf.rb_mrlock);
+       list_del(&mr->mr_all);
+       spin_unlock(&r_xprt->rx_buf.rb_mrlock);
 
-       fmr_op_release_mr(mw);
+       fmr_op_release_mr(mr);
 }
 
 static int
@@ -180,15 +180,15 @@ fmr_op_maxpages(struct rpcrdma_xprt *r_xprt)
  */
 static struct rpcrdma_mr_seg *
 fmr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg,
-          int nsegs, bool writing, struct rpcrdma_mw **out)
+          int nsegs, bool writing, struct rpcrdma_mr **out)
 {
        struct rpcrdma_mr_seg *seg1 = seg;
        int len, pageoff, i, rc;
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
        u64 *dma_pages;
 
-       mw = rpcrdma_get_mw(r_xprt);
-       if (!mw)
+       mr = rpcrdma_mr_get(r_xprt);
+       if (!mr)
                return ERR_PTR(-ENOBUFS);
 
        pageoff = offset_in_page(seg1->mr_offset);
@@ -199,12 +199,12 @@ fmr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg,
                nsegs = RPCRDMA_MAX_FMR_SGES;
        for (i = 0; i < nsegs;) {
                if (seg->mr_page)
-                       sg_set_page(&mw->mw_sg[i],
+                       sg_set_page(&mr->mr_sg[i],
                                    seg->mr_page,
                                    seg->mr_len,
                                    offset_in_page(seg->mr_offset));
                else
-                       sg_set_buf(&mw->mw_sg[i], seg->mr_offset,
+                       sg_set_buf(&mr->mr_sg[i], seg->mr_offset,
                                   seg->mr_len);
                len += seg->mr_len;
                ++seg;
@@ -214,40 +214,40 @@ fmr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg,
                    offset_in_page((seg-1)->mr_offset + (seg-1)->mr_len))
                        break;
        }
-       mw->mw_dir = rpcrdma_data_dir(writing);
+       mr->mr_dir = rpcrdma_data_dir(writing);
 
-       mw->mw_nents = ib_dma_map_sg(r_xprt->rx_ia.ri_device,
-                                    mw->mw_sg, i, mw->mw_dir);
-       if (!mw->mw_nents)
+       mr->mr_nents = ib_dma_map_sg(r_xprt->rx_ia.ri_device,
+                                    mr->mr_sg, i, mr->mr_dir);
+       if (!mr->mr_nents)
                goto out_dmamap_err;
 
-       for (i = 0, dma_pages = mw->fmr.fm_physaddrs; i < mw->mw_nents; i++)
-               dma_pages[i] = sg_dma_address(&mw->mw_sg[i]);
-       rc = ib_map_phys_fmr(mw->fmr.fm_mr, dma_pages, mw->mw_nents,
+       for (i = 0, dma_pages = mr->fmr.fm_physaddrs; i < mr->mr_nents; i++)
+               dma_pages[i] = sg_dma_address(&mr->mr_sg[i]);
+       rc = ib_map_phys_fmr(mr->fmr.fm_mr, dma_pages, mr->mr_nents,
                             dma_pages[0]);
        if (rc)
                goto out_maperr;
 
-       mw->mw_handle = mw->fmr.fm_mr->rkey;
-       mw->mw_length = len;
-       mw->mw_offset = dma_pages[0] + pageoff;
+       mr->mr_handle = mr->fmr.fm_mr->rkey;
+       mr->mr_length = len;
+       mr->mr_offset = dma_pages[0] + pageoff;
 
-       *out = mw;
+       *out = mr;
        return seg;
 
 out_dmamap_err:
        pr_err("rpcrdma: failed to DMA map sg %p sg_nents %d\n",
-              mw->mw_sg, i);
-       rpcrdma_put_mw(r_xprt, mw);
+              mr->mr_sg, i);
+       rpcrdma_mr_put(mr);
        return ERR_PTR(-EIO);
 
 out_maperr:
        pr_err("rpcrdma: ib_map_phys_fmr %u@0x%llx+%i (%d) status %i\n",
               len, (unsigned long long)dma_pages[0],
-              pageoff, mw->mw_nents, rc);
+              pageoff, mr->mr_nents, rc);
        ib_dma_unmap_sg(r_xprt->rx_ia.ri_device,
-                       mw->mw_sg, mw->mw_nents, mw->mw_dir);
-       rpcrdma_put_mw(r_xprt, mw);
+                       mr->mr_sg, mr->mr_nents, mr->mr_dir);
+       rpcrdma_mr_put(mr);
        return ERR_PTR(-EIO);
 }
 
@@ -256,13 +256,13 @@ out_maperr:
  * Sleeps until it is safe for the host CPU to access the
  * previously mapped memory regions.
  *
- * Caller ensures that @mws is not empty before the call. This
+ * Caller ensures that @mrs is not empty before the call. This
  * function empties the list.
  */
 static void
-fmr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
+fmr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mrs)
 {
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
        LIST_HEAD(unmap_list);
        int rc;
 
@@ -271,10 +271,10 @@ fmr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
         * ib_unmap_fmr() is slow, so use a single call instead
         * of one call per mapped FMR.
         */
-       list_for_each_entry(mw, mws, mw_list) {
+       list_for_each_entry(mr, mrs, mr_list) {
                dprintk("RPC:       %s: unmapping fmr %p\n",
-                       __func__, &mw->fmr);
-               list_add_tail(&mw->fmr.fm_mr->list, &unmap_list);
+                       __func__, &mr->fmr);
+               list_add_tail(&mr->fmr.fm_mr->list, &unmap_list);
        }
        r_xprt->rx_stats.local_inv_needed++;
        rc = ib_unmap_fmr(&unmap_list);
@@ -284,14 +284,14 @@ fmr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
        /* ORDER: Now DMA unmap all of the req's MRs, and return
         * them to the free MW list.
         */
-       while (!list_empty(mws)) {
-               mw = rpcrdma_pop_mw(mws);
+       while (!list_empty(mrs)) {
+               mr = rpcrdma_mr_pop(mrs);
                dprintk("RPC:       %s: DMA unmapping fmr %p\n",
-                       __func__, &mw->fmr);
-               list_del(&mw->fmr.fm_mr->list);
+                       __func__, &mr->fmr);
+               list_del(&mr->fmr.fm_mr->list);
                ib_dma_unmap_sg(r_xprt->rx_ia.ri_device,
-                               mw->mw_sg, mw->mw_nents, mw->mw_dir);
-               rpcrdma_put_mw(r_xprt, mw);
+                               mr->mr_sg, mr->mr_nents, mr->mr_dir);
+               rpcrdma_mr_put(mr);
        }
 
        return;
@@ -299,10 +299,10 @@ fmr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
 out_reset:
        pr_err("rpcrdma: ib_unmap_fmr failed (%i)\n", rc);
 
-       while (!list_empty(mws)) {
-               mw = rpcrdma_pop_mw(mws);
-               list_del(&mw->fmr.fm_mr->list);
-               fmr_op_recover_mr(mw);
+       while (!list_empty(mrs)) {
+               mr = rpcrdma_mr_pop(mrs);
+               list_del(&mr->fmr.fm_mr->list);
+               fmr_op_recover_mr(mr);
        }
 }
 
index 185eb69e5fb5c9724381c1077e264e8e5b4fbe91..8ba4b3388a982a2d972274c1a802469ace09f8ba 100644 (file)
@@ -17,7 +17,7 @@
  * A Memory Region is prepared for RDMA READ or WRITE using a FAST_REG
  * Work Request (frwr_op_map). When the RDMA operation is finished, this
  * Memory Region is invalidated using a LOCAL_INV Work Request
- * (frwr_op_unmap).
+ * (frwr_op_unmap_sync).
  *
  * Typically these Work Requests are not signaled, and neither are RDMA
  * SEND Work Requests (with the exception of signaling occasionally to
@@ -26,7 +26,7 @@
  *
  * As an optimization, frwr_op_unmap marks MRs INVALID before the
  * LOCAL_INV WR is posted. If posting succeeds, the MR is placed on
- * rb_mws immediately so that no work (like managing a linked list
+ * rb_mrs immediately so that no work (like managing a linked list
  * under a spinlock) is needed in the completion upcall.
  *
  * But this means that frwr_op_map() can occasionally encounter an MR
@@ -60,7 +60,7 @@
  * When frwr_op_map encounters FLUSHED and VALID MRs, they are recovered
  * with ib_dereg_mr and then are re-initialized. Because MR recovery
  * allocates fresh resources, it is deferred to a workqueue, and the
- * recovered MRs are placed back on the rb_mws list when recovery is
+ * recovered MRs are placed back on the rb_mrs list when recovery is
  * complete. frwr_op_map allocates another MR for the current RPC while
  * the broken MR is reset.
  *
@@ -96,21 +96,21 @@ out_not_supported:
 }
 
 static int
-frwr_op_init_mr(struct rpcrdma_ia *ia, struct rpcrdma_mw *r)
+frwr_op_init_mr(struct rpcrdma_ia *ia, struct rpcrdma_mr *mr)
 {
        unsigned int depth = ia->ri_max_frwr_depth;
-       struct rpcrdma_frwr *frwr = &r->frwr;
+       struct rpcrdma_frwr *frwr = &mr->frwr;
        int rc;
 
        frwr->fr_mr = ib_alloc_mr(ia->ri_pd, ia->ri_mrtype, depth);
        if (IS_ERR(frwr->fr_mr))
                goto out_mr_err;
 
-       r->mw_sg = kcalloc(depth, sizeof(*r->mw_sg), GFP_KERNEL);
-       if (!r->mw_sg)
+       mr->mr_sg = kcalloc(depth, sizeof(*mr->mr_sg), GFP_KERNEL);
+       if (!mr->mr_sg)
                goto out_list_err;
 
-       sg_init_table(r->mw_sg, depth);
+       sg_init_table(mr->mr_sg, depth);
        init_completion(&frwr->fr_linv_done);
        return 0;
 
@@ -129,32 +129,32 @@ out_list_err:
 }
 
 static void
-frwr_op_release_mr(struct rpcrdma_mw *r)
+frwr_op_release_mr(struct rpcrdma_mr *mr)
 {
        int rc;
 
-       /* Ensure MW is not on any rl_registered list */
-       if (!list_empty(&r->mw_list))
-               list_del(&r->mw_list);
+       /* Ensure MR is not on any rl_registered list */
+       if (!list_empty(&mr->mr_list))
+               list_del(&mr->mr_list);
 
-       rc = ib_dereg_mr(r->frwr.fr_mr);
+       rc = ib_dereg_mr(mr->frwr.fr_mr);
        if (rc)
                pr_err("rpcrdma: final ib_dereg_mr for %p returned %i\n",
-                      r, rc);
-       kfree(r->mw_sg);
-       kfree(r);
+                      mr, rc);
+       kfree(mr->mr_sg);
+       kfree(mr);
 }
 
 static int
-__frwr_reset_mr(struct rpcrdma_ia *ia, struct rpcrdma_mw *r)
+__frwr_mr_reset(struct rpcrdma_ia *ia, struct rpcrdma_mr *mr)
 {
-       struct rpcrdma_frwr *frwr = &r->frwr;
+       struct rpcrdma_frwr *frwr = &mr->frwr;
        int rc;
 
        rc = ib_dereg_mr(frwr->fr_mr);
        if (rc) {
                pr_warn("rpcrdma: ib_dereg_mr status %d, frwr %p orphaned\n",
-                       rc, r);
+                       rc, mr);
                return rc;
        }
 
@@ -162,7 +162,7 @@ __frwr_reset_mr(struct rpcrdma_ia *ia, struct rpcrdma_mw *r)
                                  ia->ri_max_frwr_depth);
        if (IS_ERR(frwr->fr_mr)) {
                pr_warn("rpcrdma: ib_alloc_mr status %ld, frwr %p orphaned\n",
-                       PTR_ERR(frwr->fr_mr), r);
+                       PTR_ERR(frwr->fr_mr), mr);
                return PTR_ERR(frwr->fr_mr);
        }
 
@@ -174,33 +174,33 @@ __frwr_reset_mr(struct rpcrdma_ia *ia, struct rpcrdma_mw *r)
 /* Reset of a single FRWR. Generate a fresh rkey by replacing the MR.
  */
 static void
-frwr_op_recover_mr(struct rpcrdma_mw *mw)
+frwr_op_recover_mr(struct rpcrdma_mr *mr)
 {
-       enum rpcrdma_frwr_state state = mw->frwr.fr_state;
-       struct rpcrdma_xprt *r_xprt = mw->mw_xprt;
+       enum rpcrdma_frwr_state state = mr->frwr.fr_state;
+       struct rpcrdma_xprt *r_xprt = mr->mr_xprt;
        struct rpcrdma_ia *ia = &r_xprt->rx_ia;
        int rc;
 
-       rc = __frwr_reset_mr(ia, mw);
+       rc = __frwr_mr_reset(ia, mr);
        if (state != FRWR_FLUSHED_LI)
                ib_dma_unmap_sg(ia->ri_device,
-                               mw->mw_sg, mw->mw_nents, mw->mw_dir);
+                               mr->mr_sg, mr->mr_nents, mr->mr_dir);
        if (rc)
                goto out_release;
 
-       rpcrdma_put_mw(r_xprt, mw);
+       rpcrdma_mr_put(mr);
        r_xprt->rx_stats.mrs_recovered++;
        return;
 
 out_release:
-       pr_err("rpcrdma: FRWR reset failed %d, %p release\n", rc, mw);
+       pr_err("rpcrdma: FRWR reset failed %d, %p release\n", rc, mr);
        r_xprt->rx_stats.mrs_orphaned++;
 
-       spin_lock(&r_xprt->rx_buf.rb_mwlock);
-       list_del(&mw->mw_all);
-       spin_unlock(&r_xprt->rx_buf.rb_mwlock);
+       spin_lock(&r_xprt->rx_buf.rb_mrlock);
+       list_del(&mr->mr_all);
+       spin_unlock(&r_xprt->rx_buf.rb_mrlock);
 
-       frwr_op_release_mr(mw);
+       frwr_op_release_mr(mr);
 }
 
 static int
@@ -347,40 +347,39 @@ frwr_wc_localinv_wake(struct ib_cq *cq, struct ib_wc *wc)
  */
 static struct rpcrdma_mr_seg *
 frwr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg,
-           int nsegs, bool writing, struct rpcrdma_mw **out)
+           int nsegs, bool writing, struct rpcrdma_mr **out)
 {
        struct rpcrdma_ia *ia = &r_xprt->rx_ia;
        bool holes_ok = ia->ri_mrtype == IB_MR_TYPE_SG_GAPS;
        struct rpcrdma_frwr *frwr;
-       struct rpcrdma_mw *mw;
-       struct ib_mr *mr;
+       struct rpcrdma_mr *mr;
+       struct ib_mr *ibmr;
        struct ib_reg_wr *reg_wr;
        struct ib_send_wr *bad_wr;
        int rc, i, n;
        u8 key;
 
-       mw = NULL;
+       mr = NULL;
        do {
-               if (mw)
-                       rpcrdma_defer_mr_recovery(mw);
-               mw = rpcrdma_get_mw(r_xprt);
-               if (!mw)
+               if (mr)
+                       rpcrdma_mr_defer_recovery(mr);
+               mr = rpcrdma_mr_get(r_xprt);
+               if (!mr)
                        return ERR_PTR(-ENOBUFS);
-       } while (mw->frwr.fr_state != FRWR_IS_INVALID);
-       frwr = &mw->frwr;
+       } while (mr->frwr.fr_state != FRWR_IS_INVALID);
+       frwr = &mr->frwr;
        frwr->fr_state = FRWR_IS_VALID;
-       mr = frwr->fr_mr;
 
        if (nsegs > ia->ri_max_frwr_depth)
                nsegs = ia->ri_max_frwr_depth;
        for (i = 0; i < nsegs;) {
                if (seg->mr_page)
-                       sg_set_page(&mw->mw_sg[i],
+                       sg_set_page(&mr->mr_sg[i],
                                    seg->mr_page,
                                    seg->mr_len,
                                    offset_in_page(seg->mr_offset));
                else
-                       sg_set_buf(&mw->mw_sg[i], seg->mr_offset,
+                       sg_set_buf(&mr->mr_sg[i], seg->mr_offset,
                                   seg->mr_len);
 
                ++seg;
@@ -391,21 +390,22 @@ frwr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg,
                    offset_in_page((seg-1)->mr_offset + (seg-1)->mr_len))
                        break;
        }
-       mw->mw_dir = rpcrdma_data_dir(writing);
+       mr->mr_dir = rpcrdma_data_dir(writing);
 
-       mw->mw_nents = ib_dma_map_sg(ia->ri_device, mw->mw_sg, i, mw->mw_dir);
-       if (!mw->mw_nents)
+       mr->mr_nents = ib_dma_map_sg(ia->ri_device, mr->mr_sg, i, mr->mr_dir);
+       if (!mr->mr_nents)
                goto out_dmamap_err;
 
-       n = ib_map_mr_sg(mr, mw->mw_sg, mw->mw_nents, NULL, PAGE_SIZE);
-       if (unlikely(n != mw->mw_nents))
+       ibmr = frwr->fr_mr;
+       n = ib_map_mr_sg(ibmr, mr->mr_sg, mr->mr_nents, NULL, PAGE_SIZE);
+       if (unlikely(n != mr->mr_nents))
                goto out_mapmr_err;
 
        dprintk("RPC:       %s: Using frwr %p to map %u segments (%llu bytes)\n",
-               __func__, frwr, mw->mw_nents, mr->length);
+               __func__, frwr, mr->mr_nents, ibmr->length);
 
-       key = (u8)(mr->rkey & 0x000000FF);
-       ib_update_fast_reg_key(mr, ++key);
+       key = (u8)(ibmr->rkey & 0x000000FF);
+       ib_update_fast_reg_key(ibmr, ++key);
 
        reg_wr = &frwr->fr_regwr;
        reg_wr->wr.next = NULL;
@@ -414,8 +414,8 @@ frwr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg,
        reg_wr->wr.wr_cqe = &frwr->fr_cqe;
        reg_wr->wr.num_sge = 0;
        reg_wr->wr.send_flags = 0;
-       reg_wr->mr = mr;
-       reg_wr->key = mr->rkey;
+       reg_wr->mr = ibmr;
+       reg_wr->key = ibmr->rkey;
        reg_wr->access = writing ?
                         IB_ACCESS_REMOTE_WRITE | IB_ACCESS_LOCAL_WRITE :
                         IB_ACCESS_REMOTE_READ;
@@ -424,48 +424,48 @@ frwr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg,
        if (rc)
                goto out_senderr;
 
-       mw->mw_handle = mr->rkey;
-       mw->mw_length = mr->length;
-       mw->mw_offset = mr->iova;
+       mr->mr_handle = ibmr->rkey;
+       mr->mr_length = ibmr->length;
+       mr->mr_offset = ibmr->iova;
 
-       *out = mw;
+       *out = mr;
        return seg;
 
 out_dmamap_err:
        pr_err("rpcrdma: failed to DMA map sg %p sg_nents %d\n",
-              mw->mw_sg, i);
+              mr->mr_sg, i);
        frwr->fr_state = FRWR_IS_INVALID;
-       rpcrdma_put_mw(r_xprt, mw);
+       rpcrdma_mr_put(mr);
        return ERR_PTR(-EIO);
 
 out_mapmr_err:
        pr_err("rpcrdma: failed to map mr %p (%d/%d)\n",
-              frwr->fr_mr, n, mw->mw_nents);
-       rpcrdma_defer_mr_recovery(mw);
+              frwr->fr_mr, n, mr->mr_nents);
+       rpcrdma_mr_defer_recovery(mr);
        return ERR_PTR(-EIO);
 
 out_senderr:
        pr_err("rpcrdma: FRWR registration ib_post_send returned %i\n", rc);
-       rpcrdma_defer_mr_recovery(mw);
+       rpcrdma_mr_defer_recovery(mr);
        return ERR_PTR(-ENOTCONN);
 }
 
-/* Handle a remotely invalidated mw on the @mws list
+/* Handle a remotely invalidated mr on the @mrs list
  */
 static void
-frwr_op_reminv(struct rpcrdma_rep *rep, struct list_head *mws)
+frwr_op_reminv(struct rpcrdma_rep *rep, struct list_head *mrs)
 {
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
 
-       list_for_each_entry(mw, mws, mw_list)
-               if (mw->mw_handle == rep->rr_inv_rkey) {
-                       struct rpcrdma_xprt *r_xprt = mw->mw_xprt;
+       list_for_each_entry(mr, mrs, mr_list)
+               if (mr->mr_handle == rep->rr_inv_rkey) {
+                       struct rpcrdma_xprt *r_xprt = mr->mr_xprt;
 
-                       list_del(&mw->mw_list);
-                       mw->frwr.fr_state = FRWR_IS_INVALID;
+                       list_del(&mr->mr_list);
+                       mr->frwr.fr_state = FRWR_IS_INVALID;
                        ib_dma_unmap_sg(r_xprt->rx_ia.ri_device,
-                                       mw->mw_sg, mw->mw_nents, mw->mw_dir);
-                       rpcrdma_put_mw(r_xprt, mw);
+                                       mr->mr_sg, mr->mr_nents, mr->mr_dir);
+                       rpcrdma_mr_put(mr);
                        break;  /* only one invalidated MR per RPC */
                }
 }
@@ -475,16 +475,16 @@ frwr_op_reminv(struct rpcrdma_rep *rep, struct list_head *mws)
  * Sleeps until it is safe for the host CPU to access the
  * previously mapped memory regions.
  *
- * Caller ensures that @mws is not empty before the call. This
+ * Caller ensures that @mrs is not empty before the call. This
  * function empties the list.
  */
 static void
-frwr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
+frwr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mrs)
 {
        struct ib_send_wr *first, **prev, *last, *bad_wr;
        struct rpcrdma_ia *ia = &r_xprt->rx_ia;
        struct rpcrdma_frwr *frwr;
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
        int count, rc;
 
        /* ORDER: Invalidate all of the MRs first
@@ -495,10 +495,11 @@ frwr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
        frwr = NULL;
        count = 0;
        prev = &first;
-       list_for_each_entry(mw, mws, mw_list) {
-               mw->frwr.fr_state = FRWR_IS_INVALID;
+       list_for_each_entry(mr, mrs, mr_list) {
+               mr->frwr.fr_state = FRWR_IS_INVALID;
+
+               frwr = &mr->frwr;
 
-               frwr = &mw->frwr;
                dprintk("RPC:       %s: invalidating frwr %p\n",
                        __func__, frwr);
 
@@ -507,7 +508,7 @@ frwr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
                memset(last, 0, sizeof(*last));
                last->wr_cqe = &frwr->fr_cqe;
                last->opcode = IB_WR_LOCAL_INV;
-               last->ex.invalidate_rkey = mw->mw_handle;
+               last->ex.invalidate_rkey = mr->mr_handle;
                count++;
 
                *prev = last;
@@ -537,16 +538,16 @@ frwr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
                goto reset_mrs;
 
        /* ORDER: Now DMA unmap all of the MRs, and return
-        * them to the free MW list.
+        * them to the free MR list.
         */
 unmap:
-       while (!list_empty(mws)) {
-               mw = rpcrdma_pop_mw(mws);
+       while (!list_empty(mrs)) {
+               mr = rpcrdma_mr_pop(mrs);
                dprintk("RPC:       %s: DMA unmapping frwr %p\n",
-                       __func__, &mw->frwr);
+                       __func__, &mr->frwr);
                ib_dma_unmap_sg(ia->ri_device,
-                               mw->mw_sg, mw->mw_nents, mw->mw_dir);
-               rpcrdma_put_mw(r_xprt, mw);
+                               mr->mr_sg, mr->mr_nents, mr->mr_dir);
+               rpcrdma_mr_put(mr);
        }
        return;
 
@@ -559,9 +560,9 @@ reset_mrs:
        while (bad_wr) {
                frwr = container_of(bad_wr, struct rpcrdma_frwr,
                                    fr_invwr);
-               mw = container_of(frwr, struct rpcrdma_mw, frwr);
+               mr = container_of(frwr, struct rpcrdma_mr, frwr);
 
-               __frwr_reset_mr(ia, mw);
+               __frwr_mr_reset(ia, mr);
 
                bad_wr = bad_wr->next;
        }
index 9207aeacd2c3e1603882e466c22c39d38613df8b..9601af01653ff5c5dd65b2c953c6ff784aa906ef 100644 (file)
@@ -292,15 +292,15 @@ encode_item_not_present(struct xdr_stream *xdr)
 }
 
 static void
-xdr_encode_rdma_segment(__be32 *iptr, struct rpcrdma_mw *mw)
+xdr_encode_rdma_segment(__be32 *iptr, struct rpcrdma_mr *mr)
 {
-       *iptr++ = cpu_to_be32(mw->mw_handle);
-       *iptr++ = cpu_to_be32(mw->mw_length);
-       xdr_encode_hyper(iptr, mw->mw_offset);
+       *iptr++ = cpu_to_be32(mr->mr_handle);
+       *iptr++ = cpu_to_be32(mr->mr_length);
+       xdr_encode_hyper(iptr, mr->mr_offset);
 }
 
 static int
-encode_rdma_segment(struct xdr_stream *xdr, struct rpcrdma_mw *mw)
+encode_rdma_segment(struct xdr_stream *xdr, struct rpcrdma_mr *mr)
 {
        __be32 *p;
 
@@ -308,12 +308,12 @@ encode_rdma_segment(struct xdr_stream *xdr, struct rpcrdma_mw *mw)
        if (unlikely(!p))
                return -EMSGSIZE;
 
-       xdr_encode_rdma_segment(p, mw);
+       xdr_encode_rdma_segment(p, mr);
        return 0;
 }
 
 static int
-encode_read_segment(struct xdr_stream *xdr, struct rpcrdma_mw *mw,
+encode_read_segment(struct xdr_stream *xdr, struct rpcrdma_mr *mr,
                    u32 position)
 {
        __be32 *p;
@@ -324,7 +324,7 @@ encode_read_segment(struct xdr_stream *xdr, struct rpcrdma_mw *mw,
 
        *p++ = xdr_one;                 /* Item present */
        *p++ = cpu_to_be32(position);
-       xdr_encode_rdma_segment(p, mw);
+       xdr_encode_rdma_segment(p, mr);
        return 0;
 }
 
@@ -348,7 +348,7 @@ rpcrdma_encode_read_list(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req,
 {
        struct xdr_stream *xdr = &req->rl_stream;
        struct rpcrdma_mr_seg *seg;
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
        unsigned int pos;
        int nsegs;
 
@@ -363,21 +363,21 @@ rpcrdma_encode_read_list(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req,
 
        do {
                seg = r_xprt->rx_ia.ri_ops->ro_map(r_xprt, seg, nsegs,
-                                                  false, &mw);
+                                                  false, &mr);
                if (IS_ERR(seg))
                        return PTR_ERR(seg);
-               rpcrdma_push_mw(mw, &req->rl_registered);
+               rpcrdma_mr_push(mr, &req->rl_registered);
 
-               if (encode_read_segment(xdr, mw, pos) < 0)
+               if (encode_read_segment(xdr, mr, pos) < 0)
                        return -EMSGSIZE;
 
                dprintk("RPC: %5u %s: pos %u %u@0x%016llx:0x%08x (%s)\n",
                        rqst->rq_task->tk_pid, __func__, pos,
-                       mw->mw_length, (unsigned long long)mw->mw_offset,
-                       mw->mw_handle, mw->mw_nents < nsegs ? "more" : "last");
+                       mr->mr_length, (unsigned long long)mr->mr_offset,
+                       mr->mr_handle, mr->mr_nents < nsegs ? "more" : "last");
 
                r_xprt->rx_stats.read_chunk_count++;
-               nsegs -= mw->mw_nents;
+               nsegs -= mr->mr_nents;
        } while (nsegs);
 
        return 0;
@@ -404,7 +404,7 @@ rpcrdma_encode_write_list(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req,
 {
        struct xdr_stream *xdr = &req->rl_stream;
        struct rpcrdma_mr_seg *seg;
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
        int nsegs, nchunks;
        __be32 *segcount;
 
@@ -425,23 +425,23 @@ rpcrdma_encode_write_list(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req,
        nchunks = 0;
        do {
                seg = r_xprt->rx_ia.ri_ops->ro_map(r_xprt, seg, nsegs,
-                                                  true, &mw);
+                                                  true, &mr);
                if (IS_ERR(seg))
                        return PTR_ERR(seg);
-               rpcrdma_push_mw(mw, &req->rl_registered);
+               rpcrdma_mr_push(mr, &req->rl_registered);
 
-               if (encode_rdma_segment(xdr, mw) < 0)
+               if (encode_rdma_segment(xdr, mr) < 0)
                        return -EMSGSIZE;
 
                dprintk("RPC: %5u %s: %u@0x016%llx:0x%08x (%s)\n",
                        rqst->rq_task->tk_pid, __func__,
-                       mw->mw_length, (unsigned long long)mw->mw_offset,
-                       mw->mw_handle, mw->mw_nents < nsegs ? "more" : "last");
+                       mr->mr_length, (unsigned long long)mr->mr_offset,
+                       mr->mr_handle, mr->mr_nents < nsegs ? "more" : "last");
 
                r_xprt->rx_stats.write_chunk_count++;
                r_xprt->rx_stats.total_rdma_request += seg->mr_len;
                nchunks++;
-               nsegs -= mw->mw_nents;
+               nsegs -= mr->mr_nents;
        } while (nsegs);
 
        /* Update count of segments in this Write chunk */
@@ -468,7 +468,7 @@ rpcrdma_encode_reply_chunk(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req,
 {
        struct xdr_stream *xdr = &req->rl_stream;
        struct rpcrdma_mr_seg *seg;
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
        int nsegs, nchunks;
        __be32 *segcount;
 
@@ -487,23 +487,23 @@ rpcrdma_encode_reply_chunk(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req,
        nchunks = 0;
        do {
                seg = r_xprt->rx_ia.ri_ops->ro_map(r_xprt, seg, nsegs,
-                                                  true, &mw);
+                                                  true, &mr);
                if (IS_ERR(seg))
                        return PTR_ERR(seg);
-               rpcrdma_push_mw(mw, &req->rl_registered);
+               rpcrdma_mr_push(mr, &req->rl_registered);
 
-               if (encode_rdma_segment(xdr, mw) < 0)
+               if (encode_rdma_segment(xdr, mr) < 0)
                        return -EMSGSIZE;
 
                dprintk("RPC: %5u %s: %u@0x%016llx:0x%08x (%s)\n",
                        rqst->rq_task->tk_pid, __func__,
-                       mw->mw_length, (unsigned long long)mw->mw_offset,
-                       mw->mw_handle, mw->mw_nents < nsegs ? "more" : "last");
+                       mr->mr_length, (unsigned long long)mr->mr_offset,
+                       mr->mr_handle, mr->mr_nents < nsegs ? "more" : "last");
 
                r_xprt->rx_stats.reply_chunk_count++;
                r_xprt->rx_stats.total_rdma_request += seg->mr_len;
                nchunks++;
-               nsegs -= mw->mw_nents;
+               nsegs -= mr->mr_nents;
        } while (nsegs);
 
        /* Update count of segments in the Reply chunk */
@@ -821,10 +821,10 @@ rpcrdma_marshal_req(struct rpcrdma_xprt *r_xprt, struct rpc_rqst *rqst)
         * so these registrations are invalid and unusable.
         */
        while (unlikely(!list_empty(&req->rl_registered))) {
-               struct rpcrdma_mw *mw;
+               struct rpcrdma_mr *mr;
 
-               mw = rpcrdma_pop_mw(&req->rl_registered);
-               rpcrdma_defer_mr_recovery(mw);
+               mr = rpcrdma_mr_pop(&req->rl_registered);
+               rpcrdma_mr_defer_recovery(mr);
        }
 
        /* This implementation supports the following combinations
index 840579919ad04425c55925adf95ce9aacb46f423..2582729f8c644483ed8f5eab41410cc97d649e40 100644 (file)
@@ -71,8 +71,8 @@
 /*
  * internal functions
  */
-static void rpcrdma_create_mrs(struct rpcrdma_xprt *r_xprt);
-static void rpcrdma_destroy_mrs(struct rpcrdma_buffer *buf);
+static void rpcrdma_mrs_create(struct rpcrdma_xprt *r_xprt);
+static void rpcrdma_mrs_destroy(struct rpcrdma_buffer *buf);
 static void rpcrdma_dma_unmap_regbuf(struct rpcrdma_regbuf *rb);
 
 struct workqueue_struct *rpcrdma_receive_wq __read_mostly;
@@ -458,7 +458,7 @@ rpcrdma_ia_remove(struct rpcrdma_ia *ia)
                rpcrdma_dma_unmap_regbuf(req->rl_sendbuf);
                rpcrdma_dma_unmap_regbuf(req->rl_recvbuf);
        }
-       rpcrdma_destroy_mrs(buf);
+       rpcrdma_mrs_destroy(buf);
 
        /* Allow waiters to continue */
        complete(&ia->ri_remove_done);
@@ -671,7 +671,7 @@ rpcrdma_ep_recreate_xprt(struct rpcrdma_xprt *r_xprt,
                goto out3;
        }
 
-       rpcrdma_create_mrs(r_xprt);
+       rpcrdma_mrs_create(r_xprt);
        return 0;
 
 out3:
@@ -992,15 +992,15 @@ rpcrdma_mr_recovery_worker(struct work_struct *work)
 {
        struct rpcrdma_buffer *buf = container_of(work, struct rpcrdma_buffer,
                                                  rb_recovery_worker.work);
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
 
        spin_lock(&buf->rb_recovery_lock);
        while (!list_empty(&buf->rb_stale_mrs)) {
-               mw = rpcrdma_pop_mw(&buf->rb_stale_mrs);
+               mr = rpcrdma_mr_pop(&buf->rb_stale_mrs);
                spin_unlock(&buf->rb_recovery_lock);
 
-               dprintk("RPC:       %s: recovering MR %p\n", __func__, mw);
-               mw->mw_xprt->rx_ia.ri_ops->ro_recover_mr(mw);
+               dprintk("RPC:       %s: recovering MR %p\n", __func__, mr);
+               mr->mr_xprt->rx_ia.ri_ops->ro_recover_mr(mr);
 
                spin_lock(&buf->rb_recovery_lock);
        }
@@ -1008,20 +1008,20 @@ rpcrdma_mr_recovery_worker(struct work_struct *work)
 }
 
 void
-rpcrdma_defer_mr_recovery(struct rpcrdma_mw *mw)
+rpcrdma_mr_defer_recovery(struct rpcrdma_mr *mr)
 {
-       struct rpcrdma_xprt *r_xprt = mw->mw_xprt;
+       struct rpcrdma_xprt *r_xprt = mr->mr_xprt;
        struct rpcrdma_buffer *buf = &r_xprt->rx_buf;
 
        spin_lock(&buf->rb_recovery_lock);
-       rpcrdma_push_mw(mw, &buf->rb_stale_mrs);
+       rpcrdma_mr_push(mr, &buf->rb_stale_mrs);
        spin_unlock(&buf->rb_recovery_lock);
 
        schedule_delayed_work(&buf->rb_recovery_worker, 0);
 }
 
 static void
-rpcrdma_create_mrs(struct rpcrdma_xprt *r_xprt)
+rpcrdma_mrs_create(struct rpcrdma_xprt *r_xprt)
 {
        struct rpcrdma_buffer *buf = &r_xprt->rx_buf;
        struct rpcrdma_ia *ia = &r_xprt->rx_ia;
@@ -1030,30 +1030,30 @@ rpcrdma_create_mrs(struct rpcrdma_xprt *r_xprt)
        LIST_HEAD(all);
 
        for (count = 0; count < 32; count++) {
-               struct rpcrdma_mw *mw;
+               struct rpcrdma_mr *mr;
                int rc;
 
-               mw = kzalloc(sizeof(*mw), GFP_KERNEL);
-               if (!mw)
+               mr = kzalloc(sizeof(*mr), GFP_KERNEL);
+               if (!mr)
                        break;
 
-               rc = ia->ri_ops->ro_init_mr(ia, mw);
+               rc = ia->ri_ops->ro_init_mr(ia, mr);
                if (rc) {
-                       kfree(mw);
+                       kfree(mr);
                        break;
                }
 
-               mw->mw_xprt = r_xprt;
+               mr->mr_xprt = r_xprt;
 
-               list_add(&mw->mw_list, &free);
-               list_add(&mw->mw_all, &all);
+               list_add(&mr->mr_list, &free);
+               list_add(&mr->mr_all, &all);
        }
 
-       spin_lock(&buf->rb_mwlock);
-       list_splice(&free, &buf->rb_mws);
+       spin_lock(&buf->rb_mrlock);
+       list_splice(&free, &buf->rb_mrs);
        list_splice(&all, &buf->rb_all);
        r_xprt->rx_stats.mrs_allocated += count;
-       spin_unlock(&buf->rb_mwlock);
+       spin_unlock(&buf->rb_mrlock);
 
        dprintk("RPC:       %s: created %u MRs\n", __func__, count);
 }
@@ -1066,7 +1066,7 @@ rpcrdma_mr_refresh_worker(struct work_struct *work)
        struct rpcrdma_xprt *r_xprt = container_of(buf, struct rpcrdma_xprt,
                                                   rx_buf);
 
-       rpcrdma_create_mrs(r_xprt);
+       rpcrdma_mrs_create(r_xprt);
 }
 
 struct rpcrdma_req *
@@ -1144,10 +1144,10 @@ rpcrdma_buffer_create(struct rpcrdma_xprt *r_xprt)
 
        buf->rb_max_requests = r_xprt->rx_data.max_requests;
        buf->rb_bc_srv_max_requests = 0;
-       spin_lock_init(&buf->rb_mwlock);
+       spin_lock_init(&buf->rb_mrlock);
        spin_lock_init(&buf->rb_lock);
        spin_lock_init(&buf->rb_recovery_lock);
-       INIT_LIST_HEAD(&buf->rb_mws);
+       INIT_LIST_HEAD(&buf->rb_mrs);
        INIT_LIST_HEAD(&buf->rb_all);
        INIT_LIST_HEAD(&buf->rb_stale_mrs);
        INIT_DELAYED_WORK(&buf->rb_refresh_worker,
@@ -1155,7 +1155,7 @@ rpcrdma_buffer_create(struct rpcrdma_xprt *r_xprt)
        INIT_DELAYED_WORK(&buf->rb_recovery_worker,
                          rpcrdma_mr_recovery_worker);
 
-       rpcrdma_create_mrs(r_xprt);
+       rpcrdma_mrs_create(r_xprt);
 
        INIT_LIST_HEAD(&buf->rb_send_bufs);
        INIT_LIST_HEAD(&buf->rb_allreqs);
@@ -1229,26 +1229,26 @@ rpcrdma_destroy_req(struct rpcrdma_req *req)
 }
 
 static void
-rpcrdma_destroy_mrs(struct rpcrdma_buffer *buf)
+rpcrdma_mrs_destroy(struct rpcrdma_buffer *buf)
 {
        struct rpcrdma_xprt *r_xprt = container_of(buf, struct rpcrdma_xprt,
                                                   rx_buf);
        struct rpcrdma_ia *ia = rdmab_to_ia(buf);
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
        unsigned int count;
 
        count = 0;
-       spin_lock(&buf->rb_mwlock);
+       spin_lock(&buf->rb_mrlock);
        while (!list_empty(&buf->rb_all)) {
-               mw = list_entry(buf->rb_all.next, struct rpcrdma_mw, mw_all);
-               list_del(&mw->mw_all);
+               mr = list_entry(buf->rb_all.next, struct rpcrdma_mr, mr_all);
+               list_del(&mr->mr_all);
 
-               spin_unlock(&buf->rb_mwlock);
-               ia->ri_ops->ro_release_mr(mw);
+               spin_unlock(&buf->rb_mrlock);
+               ia->ri_ops->ro_release_mr(mr);
                count++;
-               spin_lock(&buf->rb_mwlock);
+               spin_lock(&buf->rb_mrlock);
        }
-       spin_unlock(&buf->rb_mwlock);
+       spin_unlock(&buf->rb_mrlock);
        r_xprt->rx_stats.mrs_allocated = 0;
 
        dprintk("RPC:       %s: released %u MRs\n", __func__, count);
@@ -1285,26 +1285,33 @@ rpcrdma_buffer_destroy(struct rpcrdma_buffer *buf)
        spin_unlock(&buf->rb_reqslock);
        buf->rb_recv_count = 0;
 
-       rpcrdma_destroy_mrs(buf);
+       rpcrdma_mrs_destroy(buf);
 }
 
-struct rpcrdma_mw *
-rpcrdma_get_mw(struct rpcrdma_xprt *r_xprt)
+/**
+ * rpcrdma_mr_get - Allocate an rpcrdma_mr object
+ * @r_xprt: controlling transport
+ *
+ * Returns an initialized rpcrdma_mr or NULL if no free
+ * rpcrdma_mr objects are available.
+ */
+struct rpcrdma_mr *
+rpcrdma_mr_get(struct rpcrdma_xprt *r_xprt)
 {
        struct rpcrdma_buffer *buf = &r_xprt->rx_buf;
-       struct rpcrdma_mw *mw = NULL;
+       struct rpcrdma_mr *mr = NULL;
 
-       spin_lock(&buf->rb_mwlock);
-       if (!list_empty(&buf->rb_mws))
-               mw = rpcrdma_pop_mw(&buf->rb_mws);
-       spin_unlock(&buf->rb_mwlock);
+       spin_lock(&buf->rb_mrlock);
+       if (!list_empty(&buf->rb_mrs))
+               mr = rpcrdma_mr_pop(&buf->rb_mrs);
+       spin_unlock(&buf->rb_mrlock);
 
-       if (!mw)
-               goto out_nomws;
-       return mw;
+       if (!mr)
+               goto out_nomrs;
+       return mr;
 
-out_nomws:
-       dprintk("RPC:       %s: no MWs available\n", __func__);
+out_nomrs:
+       dprintk("RPC:       %s: no MRs available\n", __func__);
        if (r_xprt->rx_ep.rep_connected != -ENODEV)
                schedule_delayed_work(&buf->rb_refresh_worker, 0);
 
@@ -1314,14 +1321,20 @@ out_nomws:
        return NULL;
 }
 
+/**
+ * rpcrdma_mr_put - Release an rpcrdma_mr object
+ * @mr: object to release
+ *
+ */
 void
-rpcrdma_put_mw(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mw *mw)
+rpcrdma_mr_put(struct rpcrdma_mr *mr)
 {
+       struct rpcrdma_xprt *r_xprt = mr->mr_xprt;
        struct rpcrdma_buffer *buf = &r_xprt->rx_buf;
 
-       spin_lock(&buf->rb_mwlock);
-       rpcrdma_push_mw(mw, &buf->rb_mws);
-       spin_unlock(&buf->rb_mwlock);
+       spin_lock(&buf->rb_mrlock);
+       rpcrdma_mr_push(mr, &buf->rb_mrs);
+       spin_unlock(&buf->rb_mrlock);
 }
 
 static struct rpcrdma_rep *
index f52269afaa09dc7a44e37847d838d1794795a481..530ace6ed125eab61715171f5f73b7c2d336e214 100644 (file)
@@ -230,12 +230,12 @@ enum {
 };
 
 /*
- * struct rpcrdma_mw - external memory region metadata
+ * struct rpcrdma_mr - external memory region metadata
  *
  * An external memory region is any buffer or page that is registered
  * on the fly (ie, not pre-registered).
  *
- * Each rpcrdma_buffer has a list of free MWs anchored in rb_mws. During
+ * Each rpcrdma_buffer has a list of free MWs anchored in rb_mrs. During
  * call_allocate, rpcrdma_buffer_get() assigns one to each segment in
  * an rpcrdma_req. Then rpcrdma_register_external() grabs these to keep
  * track of registration metadata while each RPC is pending.
@@ -265,20 +265,20 @@ struct rpcrdma_fmr {
        u64                     *fm_physaddrs;
 };
 
-struct rpcrdma_mw {
-       struct list_head        mw_list;
-       struct scatterlist      *mw_sg;
-       int                     mw_nents;
-       enum dma_data_direction mw_dir;
+struct rpcrdma_mr {
+       struct list_head        mr_list;
+       struct scatterlist      *mr_sg;
+       int                     mr_nents;
+       enum dma_data_direction mr_dir;
        union {
                struct rpcrdma_fmr      fmr;
                struct rpcrdma_frwr     frwr;
        };
-       struct rpcrdma_xprt     *mw_xprt;
-       u32                     mw_handle;
-       u32                     mw_length;
-       u64                     mw_offset;
-       struct list_head        mw_all;
+       struct rpcrdma_xprt     *mr_xprt;
+       u32                     mr_handle;
+       u32                     mr_length;
+       u64                     mr_offset;
+       struct list_head        mr_all;
 };
 
 /*
@@ -371,19 +371,19 @@ rpcr_to_rdmar(struct rpc_rqst *rqst)
 }
 
 static inline void
-rpcrdma_push_mw(struct rpcrdma_mw *mw, struct list_head *list)
+rpcrdma_mr_push(struct rpcrdma_mr *mr, struct list_head *list)
 {
-       list_add_tail(&mw->mw_list, list);
+       list_add_tail(&mr->mr_list, list);
 }
 
-static inline struct rpcrdma_mw *
-rpcrdma_pop_mw(struct list_head *list)
+static inline struct rpcrdma_mr *
+rpcrdma_mr_pop(struct list_head *list)
 {
-       struct rpcrdma_mw *mw;
+       struct rpcrdma_mr *mr;
 
-       mw = list_first_entry(list, struct rpcrdma_mw, mw_list);
-       list_del(&mw->mw_list);
-       return mw;
+       mr = list_first_entry(list, struct rpcrdma_mr, mr_list);
+       list_del(&mr->mr_list);
+       return mr;
 }
 
 /*
@@ -393,8 +393,8 @@ rpcrdma_pop_mw(struct list_head *list)
  * One of these is associated with a transport instance
  */
 struct rpcrdma_buffer {
-       spinlock_t              rb_mwlock;      /* protect rb_mws list */
-       struct list_head        rb_mws;
+       spinlock_t              rb_mrlock;      /* protect rb_mrs list */
+       struct list_head        rb_mrs;
        struct list_head        rb_all;
 
        unsigned long           rb_sc_head;
@@ -473,19 +473,19 @@ struct rpcrdma_memreg_ops {
        struct rpcrdma_mr_seg *
                        (*ro_map)(struct rpcrdma_xprt *,
                                  struct rpcrdma_mr_seg *, int, bool,
-                                 struct rpcrdma_mw **);
+                                 struct rpcrdma_mr **);
        void            (*ro_reminv)(struct rpcrdma_rep *rep,
-                                    struct list_head *mws);
+                                    struct list_head *mrs);
        void            (*ro_unmap_sync)(struct rpcrdma_xprt *,
                                         struct list_head *);
-       void            (*ro_recover_mr)(struct rpcrdma_mw *);
+       void            (*ro_recover_mr)(struct rpcrdma_mr *mr);
        int             (*ro_open)(struct rpcrdma_ia *,
                                   struct rpcrdma_ep *,
                                   struct rpcrdma_create_data_internal *);
        size_t          (*ro_maxpages)(struct rpcrdma_xprt *);
        int             (*ro_init_mr)(struct rpcrdma_ia *,
-                                     struct rpcrdma_mw *);
-       void            (*ro_release_mr)(struct rpcrdma_mw *);
+                                     struct rpcrdma_mr *);
+       void            (*ro_release_mr)(struct rpcrdma_mr *mr);
        const char      *ro_displayname;
        const int       ro_send_w_inv_ok;
 };
@@ -574,15 +574,15 @@ void rpcrdma_buffer_destroy(struct rpcrdma_buffer *);
 struct rpcrdma_sendctx *rpcrdma_sendctx_get_locked(struct rpcrdma_buffer *buf);
 void rpcrdma_sendctx_put_locked(struct rpcrdma_sendctx *sc);
 
-struct rpcrdma_mw *rpcrdma_get_mw(struct rpcrdma_xprt *);
-void rpcrdma_put_mw(struct rpcrdma_xprt *, struct rpcrdma_mw *);
+struct rpcrdma_mr *rpcrdma_mr_get(struct rpcrdma_xprt *r_xprt);
+void rpcrdma_mr_put(struct rpcrdma_mr *mr);
+void rpcrdma_mr_defer_recovery(struct rpcrdma_mr *mr);
+
 struct rpcrdma_req *rpcrdma_buffer_get(struct rpcrdma_buffer *);
 void rpcrdma_buffer_put(struct rpcrdma_req *);
 void rpcrdma_recv_buffer_get(struct rpcrdma_req *);
 void rpcrdma_recv_buffer_put(struct rpcrdma_rep *);
 
-void rpcrdma_defer_mr_recovery(struct rpcrdma_mw *);
-
 struct rpcrdma_regbuf *rpcrdma_alloc_regbuf(size_t, enum dma_data_direction,
                                            gfp_t);
 bool __rpcrdma_dma_map_regbuf(struct rpcrdma_ia *, struct rpcrdma_regbuf *);