drm/i915: Fix skl srckey mask bits
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 25 Jan 2019 18:38:46 +0000 (20:38 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 29 Jan 2019 16:44:56 +0000 (18:44 +0200)
We're incorrectly masking off the R/V channel enable bit from
KEYMSK. Fix it up.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Fixes: b20815255693 ("drm/i915: Add plane alpha blending support, v2.")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190125183846.28755-1-ville.syrjala@linux.intel.com
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
drivers/gpu/drm/i915/intel_sprite.c

index b02d3d9809e30e598942230940263de866c25b17..cd42e81f8a90112603602851e296a65b1236ce0a 100644 (file)
@@ -493,7 +493,7 @@ skl_program_plane(struct intel_plane *plane,
 
        keymax = (key->max_value & 0xffffff) | PLANE_KEYMAX_ALPHA(alpha);
 
-       keymsk = key->channel_mask & 0x3ffffff;
+       keymsk = key->channel_mask & 0x7ffffff;
        if (alpha < 0xff)
                keymsk |= PLANE_KEYMSK_ALPHA_ENABLE;