projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ac16ca6
)
[6PACK]: Masking bug in 6pack driver.
author
Jean Delvare
<khali@linux-fr.org>
Thu, 23 Nov 2006 19:48:28 +0000
(11:48 -0800)
committer
David S. Miller
<davem@sunset.davemloft.net>
Sat, 25 Nov 2006 23:16:50 +0000
(15:16 -0800)
Looks like a broken masking to me, binary not is used where bitwise
not was intended.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hamradio/6pack.c
patch
|
blob
|
history
diff --git
a/drivers/net/hamradio/6pack.c
b/drivers/net/hamradio/6pack.c
index 86b3bb9bec2d38727922fda410b58f73f9019fde..92420f007b97ebc79bf5c07b212a1985a50d9e3f 100644
(file)
--- a/
drivers/net/hamradio/6pack.c
+++ b/
drivers/net/hamradio/6pack.c
@@
-914,7
+914,7
@@
static void decode_prio_command(struct sixpack *sp, unsigned char cmd)
printk(KERN_DEBUG "6pack: protocol violation\n");
else
sp->status = 0;
- cmd &=
!
SIXP_RX_DCD_MASK;
+ cmd &=
~
SIXP_RX_DCD_MASK;
}
sp->status = cmd & SIXP_PRIO_DATA_MASK;
} else { /* output watchdog char if idle */