ath79: use rssihigh LED instead of WAN LED for status indication
authorAdrian Schmutzler <freifunk@adrianschmutzler.de>
Sat, 18 Jan 2020 17:58:10 +0000 (18:58 +0100)
committerAdrian Schmutzler <freifunk@adrianschmutzler.de>
Sat, 18 Jan 2020 18:39:05 +0000 (19:39 +0100)
Using the LED of network interfaces for status (boot/failsafe/...)
indication is somewhat misleading, as the blinking might be
mistaken for network activity. This uses rssi LEDs instead, which
do not blink normally and thus are less ambiguous.

The rssihigh LED has also been used consistently for the TP-Link CPE
devices.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
target/linux/ath79/dts/ar9344_comfast_cf-e120a-v3.dts
target/linux/ath79/dts/qca9533_comfast_cf-e110n-v2.dts

index 66ac718264bcbac02905aae46d037be7b64afe88..b4a5bb4709f5a2f7699be82a7ed5a95ad371d68c 100644 (file)
@@ -12,9 +12,9 @@
 
        aliases {
                serial0 = &uart;
-               led-boot = &led_wan;
-               led-failsafe = &led_wan;
-               led-upgrade = &led_wan;
+               led-boot = &led_rssihigh;
+               led-failsafe = &led_rssihigh;
+               led-upgrade = &led_rssihigh;
                label-mac-device = &eth0;
        };
 
@@ -24,7 +24,7 @@
                pinctrl-names = "default";
                pinctrl-0 = <&led_rssimediumhigh_pin>;
 
-               led_wan: wan {
+               wan {
                        label = "cf-e120a-v3:green:wan";
                        gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
                };
@@ -55,7 +55,7 @@
                        gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
                };
 
-               rssihigh {
+               led_rssihigh: rssihigh {
                        label = "cf-e120a-v3:green:rssihigh";
                        gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
                };
index 0d01342685f8895ad3a8100da512ad5593653651..45e3727daad225df22b15b5d1fcab08989ce4b4a 100644 (file)
@@ -12,9 +12,9 @@
 
        aliases {
                serial0 = &uart;
-               led-boot = &led_wan;
-               led-failsafe = &led_wan;
-               led-upgrade = &led_wan;
+               led-boot = &led_rssihigh;
+               led-failsafe = &led_rssihigh;
+               led-upgrade = &led_rssihigh;
        };
 
        leds {
@@ -23,7 +23,7 @@
                pinctrl-names = "default";
                pinctrl-0 = <&jtag_disable_pins &led_rssilow_pin &led_rssimediumhigh_pin &led_rssihigh_pin>;
 
-               led_wan: wan {
+               wan {
                        label = "cf-e110n-v2:green:wan";
                        gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
                };
@@ -48,7 +48,7 @@
                        gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
                };
 
-               rssihigh {
+               led_rssihigh: rssihigh {
                        label = "cf-e110n-v2:green:rssihigh";
                        gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
                };