net: ethernet: mediatek: Fix misuses of GENMASK macro

Arguments are supposed to be ordered high then low.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h
index c6be599ed94d3775bb65648205d8c3783dd8b1f8..bab94f763e2cc175a11664dcdd59e5d215acc4b0 100644 (file)
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h
@@ -723,7 +723,7 @@ struct mtk_soc_data {
 #define MTK_MAX_DEVS                   2
 
 #define MTK_SGMII_PHYSPEED_AN          BIT(31)
-#define MTK_SGMII_PHYSPEED_MASK        GENMASK(0, 2)
+#define MTK_SGMII_PHYSPEED_MASK        GENMASK(2, 0)
 #define MTK_SGMII_PHYSPEED_1000        BIT(0)
 #define MTK_SGMII_PHYSPEED_2500        BIT(1)
 #define MTK_HAS_FLAGS(flags, _x)       (((flags) & (_x)) == (_x))

diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c
index 136f90ce5a6536dfc816001a9a9750bd2d600473..ff509d42d81855ab570035b24c4cdba561edc1fc 100644 (file)
--- a/drivers/net/ethernet/mediatek/mtk_sgmii.c
+++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c
@@ -82,7 +82,7 @@ int mtk_sgmii_setup_mode_force(struct mtk_sgmii *ss, int id)
                return -EINVAL;
 
        regmap_read(ss->regmap[id], ss->ana_rgc3, &val);
-       val &= ~GENMASK(2, 3);
+       val &= ~GENMASK(3, 2);
        mode = ss->flags[id] & MTK_SGMII_PHYSPEED_MASK;
        val |= (mode == MTK_SGMII_PHYSPEED_1000) ? 0 : BIT(2);
        regmap_write(ss->regmap[id], ss->ana_rgc3, val);