drm/v3d: Make sure the GPU is on when measuring clocks.
authorEric Anholt <eric@anholt.net>
Wed, 20 Feb 2019 23:36:58 +0000 (15:36 -0800)
committerEric Anholt <eric@anholt.net>
Fri, 8 Mar 2019 16:59:35 +0000 (08:59 -0800)
You'll get garbage measurements if the registers always read back
0xdeadbeef

Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190220233658.986-3-eric@anholt.net
Reviewed-by: Dave Emett <david.emett@broadcom.com>
drivers/gpu/drm/v3d/v3d_debugfs.c

index eb2b2d2f85538381810b1ecc915ac3e128d9bc8f..a24af2d2f5748b3cf4f786331c2ef80e82c5104a 100644 (file)
@@ -187,6 +187,11 @@ static int v3d_measure_clock(struct seq_file *m, void *unused)
        uint32_t cycles;
        int core = 0;
        int measure_ms = 1000;
+       int ret;
+
+       ret = pm_runtime_get_sync(v3d->dev);
+       if (ret < 0)
+               return ret;
 
        if (v3d->ver >= 40) {
                V3D_CORE_WRITE(core, V3D_V4_PCTR_0_SRC_0_3,
@@ -210,6 +215,9 @@ static int v3d_measure_clock(struct seq_file *m, void *unused)
                   cycles / (measure_ms * 1000),
                   (cycles / (measure_ms * 100)) % 10);
 
+       pm_runtime_mark_last_busy(v3d->dev);
+       pm_runtime_put_autosuspend(v3d->dev);
+
        return 0;
 }