drm/selftests: Fix build warning -Wframe-larger-than
authorAlexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com>
Fri, 2 Nov 2018 13:01:25 +0000 (13:01 +0000)
committerMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Fri, 2 Nov 2018 13:25:32 +0000 (14:25 +0100)
It seems for some random configuration drm_device is bigger than 2048
bytes.
The fix is to make the mock objects static variables.

Bug reported by 0-DAY Kernel test infrastructure here:
https://lists.01.org/pipermail/kbuild-all/2018-November/054431.html

Fixes: 6ff3d9ffdcbb ("drm/selftests: Add tests for drm_internal_framebuffer_create")
Signed-off-by: Alexandru-Cosmin Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181102130103.7753-1-alexandru-cosmin.gheorghe@arm.com
drivers/gpu/drm/selftests/test-drm_framebuffer.c

index 3098435678af762ad8297a918162911730a55f46..a04d02dacce2a75be87c9e2bff553c09d8ef2945 100644 (file)
@@ -307,25 +307,27 @@ static struct drm_framebuffer *fb_create_mock(struct drm_device *dev,
        return ERR_PTR(-EINVAL);
 }
 
+static struct drm_mode_config_funcs mock_config_funcs = {
+       .fb_create = fb_create_mock,
+};
+
+static struct drm_device mock_drm_device = {
+       .mode_config = {
+               .min_width = MIN_WIDTH,
+               .max_width = MAX_WIDTH,
+               .min_height = MIN_HEIGHT,
+               .max_height = MAX_HEIGHT,
+               .allow_fb_modifiers = true,
+               .funcs = &mock_config_funcs,
+       },
+};
+
 static int execute_drm_mode_fb_cmd2(struct drm_mode_fb_cmd2 *r)
 {
        int buffer_created = 0;
        struct drm_framebuffer *fb;
-       struct drm_mode_config_funcs mock_config_funcs = {
-               .fb_create = fb_create_mock,
-       };
-       struct drm_device mock_drm_device = {
-               .mode_config = {
-                       .min_width = MIN_WIDTH,
-                       .max_width = MAX_WIDTH,
-                       .min_height = MIN_HEIGHT,
-                       .max_height = MAX_HEIGHT,
-                       .allow_fb_modifiers = true,
-                       .funcs = &mock_config_funcs,
-               },
-               .dev_private = &buffer_created
-       };
 
+       mock_drm_device.dev_private = &buffer_created;
        fb = drm_internal_framebuffer_create(&mock_drm_device, r, NULL);
        return buffer_created;
 }