scsi: xen-scsifront: mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 28 Nov 2018 04:34:35 +0000 (22:34 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 29 Nov 2018 02:47:30 +0000 (21:47 -0500)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.

Notice that, in this particular case, I replaced "Missed the backend's
Closing state -- fallthrough" with "fall through - Missed the backend's
Closing state", which contains the "fall through" annotation at the
beginnig of the code comment, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/xen-scsifront.c

index 61389bdc7926690100fc0a38fc59e8b6a73853ab..bb76d0d2022b9dadc1adb8bbb65fdae4b081fa50 100644 (file)
@@ -1112,7 +1112,7 @@ static void scsifront_backend_changed(struct xenbus_device *dev,
        case XenbusStateClosed:
                if (dev->state == XenbusStateClosed)
                        break;
-               /* Missed the backend's Closing state -- fallthrough */
+               /* fall through - Missed the backend's Closing state */
        case XenbusStateClosing:
                scsifront_disconnect(info);
                break;