drm/i915/crt: don't set HOTPLUG bits on !PCH
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 11 Oct 2012 18:08:23 +0000 (20:08 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 18 Oct 2012 12:20:40 +0000 (14:20 +0200)
... since they don't apply to pre-pch platforms and could actually be
harmful.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_crt.c

index c42b9809f86de5c21fefd55cb12e5c458fbc1d1b..46c90f532f9cfccb1388d25840d11d01ca514ea1 100644 (file)
@@ -235,7 +235,11 @@ static void intel_crt_mode_set(struct drm_encoder *encoder,
                           dpll_md & ~DPLL_MD_UDI_MULTIPLIER_MASK);
        }
 
-       adpa = ADPA_HOTPLUG_BITS;
+       if (HAS_PCH_SPLIT(dev))
+               adpa = ADPA_HOTPLUG_BITS;
+       else
+               adpa = 0;
+
        if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
                adpa |= ADPA_HSYNC_ACTIVE_HIGH;
        if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)