drm/rockchip: fix "should it be static?" warnings
authorJohn Keeping <john@metanate.com>
Tue, 10 May 2016 16:03:56 +0000 (17:03 +0100)
committerMark Yao <mark.yao@rock-chips.com>
Tue, 19 Jul 2016 01:42:19 +0000 (09:42 +0800)
Combined with the previous commit, this fixes all of the sparse warnings
in drm/rockchip.

Signed-off-by: John Keeping <john@metanate.com>
drivers/gpu/drm/rockchip/rockchip_drm_drv.c
drivers/gpu/drm/rockchip/rockchip_drm_fb.c
drivers/gpu/drm/rockchip/rockchip_drm_vop.c
drivers/gpu/drm/rockchip/rockchip_vop_reg.c

index f0bd1ee8b128300f2f453df3a0a3b80f71550a00..810042be40fd5f983048796d5ca105f0f0004185 100644 (file)
@@ -257,7 +257,7 @@ static void rockchip_drm_unbind(struct device *dev)
        dev_set_drvdata(dev, NULL);
 }
 
-void rockchip_drm_lastclose(struct drm_device *dev)
+static void rockchip_drm_lastclose(struct drm_device *dev)
 {
        struct rockchip_drm_private *priv = dev->dev_private;
 
index 4fe2ab3f5ca9f16ae6a5ab2f5401d9c0f41ccb16..b33debc0fa92fd4994ffc8b27508dd8f4b83bb08 100644 (file)
@@ -246,7 +246,7 @@ rockchip_atomic_commit_tail(struct drm_atomic_state *state)
        drm_atomic_helper_cleanup_planes(dev, state);
 }
 
-struct drm_mode_config_helper_funcs rockchip_mode_config_helpers = {
+static struct drm_mode_config_helper_funcs rockchip_mode_config_helpers = {
        .atomic_commit_tail = rockchip_atomic_commit_tail,
 };
 
index 6255e5bcd9540abcd65a7fa27df2a36587921805..e01c43560669988c7ea8f05a22df0c4ae56033d1 100644 (file)
@@ -798,7 +798,7 @@ static const struct drm_plane_helper_funcs plane_helper_funcs = {
        .atomic_disable = vop_plane_atomic_disable,
 };
 
-void vop_atomic_plane_reset(struct drm_plane *plane)
+static void vop_atomic_plane_reset(struct drm_plane *plane)
 {
        struct vop_plane_state *vop_plane_state =
                                        to_vop_plane_state(plane->state);
@@ -815,7 +815,7 @@ void vop_atomic_plane_reset(struct drm_plane *plane)
        plane->state->plane = plane;
 }
 
-struct drm_plane_state *
+static struct drm_plane_state *
 vop_atomic_plane_duplicate_state(struct drm_plane *plane)
 {
        struct vop_plane_state *old_vop_plane_state;
index 3166b46a5893fbe39a3c81fd2b928e41244066f2..52661d116ec2d4b220b33a1e355fc9abb2c1e655 100644 (file)
@@ -299,7 +299,7 @@ static int vop_remove(struct platform_device *pdev)
        return 0;
 }
 
-struct platform_driver vop_platform_driver = {
+static struct platform_driver vop_platform_driver = {
        .probe = vop_probe,
        .remove = vop_remove,
        .driver = {