SoC: imx-sgtl5000: add missing put_device()
authorWen Yang <yellowriver2010@hotmail.com>
Mon, 18 Feb 2019 15:13:47 +0000 (15:13 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 19 Feb 2019 10:47:24 +0000 (10:47 +0000)
The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.

Detected by coccinelle with the following warnings:
./sound/soc/fsl/imx-sgtl5000.c:169:1-7: ERROR: missing put_device;
call of_find_device_by_node on line 105, but without a corresponding
object release within this function.
./sound/soc/fsl/imx-sgtl5000.c:177:1-7: ERROR: missing put_device;
call of_find_device_by_node on line 105, but without a corresponding
object release within this function.

Signed-off-by: Wen Yang <yellowriver2010@hotmail.com>
Cc: Timur Tabi <timur@kernel.org>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Xiubo Li <Xiubo.Lee@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: alsa-devel@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/imx-sgtl5000.c

index b6cb80480b6058824d823302c2463b277fb15956..bf8597f57dce17692c8708f95a05da7dfbb9d50f 100644 (file)
@@ -108,6 +108,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
                ret = -EPROBE_DEFER;
                goto fail;
        }
+       put_device(&ssi_pdev->dev);
        codec_dev = of_find_i2c_device_by_node(codec_np);
        if (!codec_dev) {
                dev_dbg(&pdev->dev, "failed to find codec platform device\n");