net/ibmvnic: Fix typo in retry check
authorThomas Falcon <tlfalcon@linux.ibm.com>
Wed, 11 Dec 2019 15:38:39 +0000 (09:38 -0600)
committerJakub Kicinski <jakub.kicinski@netronome.com>
Sat, 14 Dec 2019 01:23:10 +0000 (17:23 -0800)
This conditional is missing a bang, with the intent
being to break when the retry count reaches zero.

Fixes: 476d96ca9cc5 ("ibmvnic: Bound waits for device queries")
Suggested-by: Juliet Kim <julietk@linux.vnet.ibm.com>
Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
drivers/net/ethernet/ibm/ibmvnic.c

index c900807819244b0a00931fc191d72979f4520740..830791ab4619c6f36e75f917c607220344077313 100644 (file)
@@ -184,7 +184,7 @@ static int ibmvnic_wait_for_completion(struct ibmvnic_adapter *adapter,
                        netdev_err(netdev, "Device down!\n");
                        return -ENODEV;
                }
-               if (retry--)
+               if (!retry--)
                        break;
                if (wait_for_completion_timeout(comp_done, div_timeout))
                        return 0;