gpio: omap: simplify read-modify-write

We already have a read-modify-write helper, but there's more that can
be done with a read-modify-write helper if it returned the new value.
Modify the existing helper to return the new value, and arrange for
it to take one less argument by having the caller compute the register
address.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Tested-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 369ce46e2b09fd51934b3801f6fbc47b5bd8579e..1a0890586b45287ec0f8309ca035dc7d5e3eaf09 100644 (file)
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -92,20 +92,25 @@ static inline struct gpio_bank *omap_irq_data_get_bank(struct irq_data *d)
        return gpiochip_get_data(chip);
 }
 
-static void omap_set_gpio_direction(struct gpio_bank *bank, int gpio,
-                                   int is_input)
+static inline u32 omap_gpio_rmw(void __iomem *reg, u32 mask, bool set)
 {
-       void __iomem *reg = bank->base;
-       u32 l;
+       u32 val = readl_relaxed(reg);
 
-       reg += bank->regs->direction;
-       l = readl_relaxed(reg);
-       if (is_input)
-               l |= BIT(gpio);
+       if (set)
+               val |= mask;
        else
-               l &= ~(BIT(gpio));
-       writel_relaxed(l, reg);
-       bank->context.oe = l;
+               val &= ~mask;
+
+       writel_relaxed(val, reg);
+
+       return val;
+}
+
+static void omap_set_gpio_direction(struct gpio_bank *bank, int gpio,
+                                   int is_input)
+{
+       bank->context.oe = omap_gpio_rmw(bank->base + bank->regs->direction,
+                                        BIT(gpio), is_input);
 }
 
 
@@ -131,29 +136,8 @@ static void omap_set_gpio_dataout_reg(struct gpio_bank *bank, unsigned offset,
 static void omap_set_gpio_dataout_mask(struct gpio_bank *bank, unsigned offset,
                                       int enable)
 {
-       void __iomem *reg = bank->base + bank->regs->dataout;
-       u32 gpio_bit = BIT(offset);
-       u32 l;
-
-       l = readl_relaxed(reg);
-       if (enable)
-               l |= gpio_bit;
-       else
-               l &= ~gpio_bit;
-       writel_relaxed(l, reg);
-       bank->context.dataout = l;
-}
-
-static inline void omap_gpio_rmw(void __iomem *base, u32 reg, u32 mask, bool set)
-{
-       int l = readl_relaxed(base + reg);
-
-       if (set)
-               l |= mask;
-       else
-               l &= ~mask;
-
-       writel_relaxed(l, base + reg);
+       bank->context.dataout = omap_gpio_rmw(bank->base + bank->regs->dataout,
+                                             BIT(offset), enable);
 }
 
 static inline void omap_gpio_dbck_enable(struct gpio_bank *bank)
@@ -217,16 +201,9 @@ static int omap2_set_gpio_debounce(struct gpio_bank *bank, unsigned offset,
        reg = bank->base + bank->regs->debounce;
        writel_relaxed(debounce, reg);
 
-       reg = bank->base + bank->regs->debounce_en;
-       val = readl_relaxed(reg);
-
-       if (enable)
-               val |= l;
-       else
-               val &= ~l;
+       val = omap_gpio_rmw(bank->base + bank->regs->debounce_en, l, enable);
        bank->dbck_enable_mask = val;
 
-       writel_relaxed(val, reg);
        clk_disable(bank->dbck);
        /*
         * Enable debounce clock per module.
@@ -301,9 +278,9 @@ static inline void omap_set_gpio_trigger(struct gpio_bank *bank, int gpio,
        void __iomem *base = bank->base;
        u32 gpio_bit = BIT(gpio);
 
-       omap_gpio_rmw(base, bank->regs->leveldetect0, gpio_bit,
+       omap_gpio_rmw(base + bank->regs->leveldetect0, gpio_bit,
                      trigger & IRQ_TYPE_LEVEL_LOW);
-       omap_gpio_rmw(base, bank->regs->leveldetect1, gpio_bit,
+       omap_gpio_rmw(base + bank->regs->leveldetect1, gpio_bit,
                      trigger & IRQ_TYPE_LEVEL_HIGH);
 
        /*
@@ -311,9 +288,9 @@ static inline void omap_set_gpio_trigger(struct gpio_bank *bank, int gpio,
         * to be woken from idle state.  Set the appropriate edge detection
         * in addition to the level detection.
         */
-       omap_gpio_rmw(base, bank->regs->risingdetect, gpio_bit,
+       omap_gpio_rmw(base + bank->regs->risingdetect, gpio_bit,
                      trigger & (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_LEVEL_HIGH));
-       omap_gpio_rmw(base, bank->regs->fallingdetect, gpio_bit,
+       omap_gpio_rmw(base + bank->regs->fallingdetect, gpio_bit,
                      trigger & (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_LEVEL_LOW));
 
        bank->context.leveldetect0 =
@@ -329,7 +306,7 @@ static inline void omap_set_gpio_trigger(struct gpio_bank *bank, int gpio,
                           bank->context.leveldetect1;
 
        if (likely(!(bank->non_wakeup_gpios & gpio_bit))) {
-               omap_gpio_rmw(base, bank->regs->wkup_en, gpio_bit, trigger != 0);
+               omap_gpio_rmw(base + bank->regs->wkup_en, gpio_bit, trigger != 0);
                bank->context.wake_en =
                        readl_relaxed(bank->base + bank->regs->wkup_en);
        }
@@ -414,7 +391,7 @@ static int omap_set_gpio_triggering(struct gpio_bank *bank, int gpio,
                        l |= BIT(gpio << 1);
 
                /* Enable wake-up during idle for dynamic tick */
-               omap_gpio_rmw(base, bank->regs->wkup_en, BIT(gpio), trigger);
+               omap_gpio_rmw(base + bank->regs->wkup_en, BIT(gpio), trigger);
                bank->context.wake_en =
                        readl_relaxed(bank->base + bank->regs->wkup_en);
                writel_relaxed(l, reg);
@@ -451,7 +428,7 @@ static void omap_disable_gpio_module(struct gpio_bank *bank, unsigned offset)
            !LINE_USED(bank->mod_usage, offset) &&
            !LINE_USED(bank->irq_usage, offset)) {
                /* Disable wake-up during idle for dynamic tick */
-               omap_gpio_rmw(base, bank->regs->wkup_en, BIT(offset), 0);
+               omap_gpio_rmw(base + bank->regs->wkup_en, BIT(offset), 0);
                bank->context.wake_en =
                        readl_relaxed(bank->base + bank->regs->wkup_en);
        }
@@ -1046,9 +1023,9 @@ static void omap_gpio_mod_init(struct gpio_bank *bank)
                return;
        }
 
-       omap_gpio_rmw(base, bank->regs->irqenable, l,
+       omap_gpio_rmw(base + bank->regs->irqenable, l,
                      bank->regs->irqenable_inv);
-       omap_gpio_rmw(base, bank->regs->irqstatus, l,
+       omap_gpio_rmw(base + bank->regs->irqstatus, l,
                      !bank->regs->irqenable_inv);
        if (bank->regs->debounce_en)
                writel_relaxed(0, base + bank->regs->debounce_en);
@@ -1219,8 +1196,8 @@ static void omap_gpio_idle(struct gpio_bank *bank, bool may_lose_context)
         */
        if (!bank->loses_context && bank->enabled_non_wakeup_gpios) {
                nowake = bank->enabled_non_wakeup_gpios;
-               omap_gpio_rmw(base, bank->regs->fallingdetect, nowake, ~nowake);
-               omap_gpio_rmw(base, bank->regs->risingdetect, nowake, ~nowake);
+               omap_gpio_rmw(base + bank->regs->fallingdetect, nowake, ~nowake);
+               omap_gpio_rmw(base + bank->regs->risingdetect, nowake, ~nowake);
        }
 
 update_gpio_context_count: