V4L/DVB: cx231xx: improve error handling

Return -EINVAL if we don't find the control id.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/cx231xx/cx231xx-video.c b/drivers/media/video/cx231xx/cx231xx-video.c
index 16a73eab6726aa9b7b3f1d381c1d0cb42672ba08..597c416218cf1f2430e8f794fe75473facef18d3 100644 (file)
--- a/drivers/media/video/cx231xx/cx231xx-video.c
+++ b/drivers/media/video/cx231xx/cx231xx-video.c
@@ -1902,9 +1902,12 @@ static int radio_queryctrl(struct file *file, void *priv,
        if (c->id < V4L2_CID_BASE || c->id >= V4L2_CID_LASTP1)
                return -EINVAL;
        if (c->id == V4L2_CID_AUDIO_MUTE) {
-               for (i = 0; i < CX231XX_CTLS; i++)
+               for (i = 0; i < CX231XX_CTLS; i++) {
                        if (cx231xx_ctls[i].v.id == c->id)
                                break;
+               }
+               if (i == CX231XX_CTLS)
+                       return -EINVAL;
                *c = cx231xx_ctls[i].v;
        } else
                *c = no_ctl;