fm10k: reduce the scope of the result local variable
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 8 Jul 2019 23:12:27 +0000 (16:12 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 1 Aug 2019 21:59:21 +0000 (14:59 -0700)
Reduce the scope of the result local variable in the
fm10k_iov_msg_lport_state_pf function.

This was detected by cppcheck and resolves the following warning
produced by that tool:

[fm10k_pf.c:1435]: (style) The scope of the variable 'result' can be
reduced.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_pf.c

index cb4d02629b86758f319dea42e35694714c9b4af2..e85b2f2eef05f0f4466fe7112a5fb2be816cdda8 100644 (file)
@@ -1352,7 +1352,6 @@ s32 fm10k_iov_msg_lport_state_pf(struct fm10k_hw *hw, u32 **results,
                                 struct fm10k_mbx_info *mbx)
 {
        struct fm10k_vf_info *vf_info = (struct fm10k_vf_info *)mbx;
-       u32 *result;
        s32 err = 0;
        u32 msg[2];
        u8 mode = 0;
@@ -1362,7 +1361,7 @@ s32 fm10k_iov_msg_lport_state_pf(struct fm10k_hw *hw, u32 **results,
                return FM10K_ERR_PARAM;
 
        if (!!results[FM10K_LPORT_STATE_MSG_XCAST_MODE]) {
-               result = results[FM10K_LPORT_STATE_MSG_XCAST_MODE];
+               u32 *result = results[FM10K_LPORT_STATE_MSG_XCAST_MODE];
 
                /* XCAST mode update requested */
                err = fm10k_tlv_attr_get_u8(result, &mode);