gpio: siox: Switch to IRQ_TYPE_NONE
authorLinus Walleij <linus.walleij@linaro.org>
Wed, 26 Jun 2019 08:11:17 +0000 (10:11 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 27 Jun 2019 14:56:52 +0000 (15:56 +0100)
The siox driver is hardcoding a default type of
IRQ_TYPE_EDGE_RISING to the irq helper, but this should only
be applicable to old boardfiles and odd device tree irqchips
with just onecell irq (no flags). I doubt this is the case
with the siox, I think all consumers specify the flags they
use in the device tree.

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-siox.c

index 0b44501188654debe85b88524cf0eb2bcfee3d2a..40067e1535d345d2577d14813248221757d89a82 100644 (file)
@@ -247,7 +247,7 @@ static int gpio_siox_probe(struct siox_device *sdevice)
        }
 
        ret = gpiochip_irqchip_add(&ddata->gchip, &ddata->ichip,
-                                  0, handle_level_irq, IRQ_TYPE_EDGE_RISING);
+                                  0, handle_level_irq, IRQ_TYPE_NONE);
        if (ret)
                dev_err(&sdevice->dev,
                        "Failed to register irq chip (%d)\n", ret);