[MAC80211]: improve key selection comment
authorJohannes Berg <johannes@sipsolutions.net>
Tue, 28 Aug 2007 21:01:55 +0000 (17:01 -0400)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:48:56 +0000 (16:48 -0700)
When I changed the code there I forgot to mention what happens
with multicast frames in a regular BSS and keep wondering myself
if the code is correct. Add appropriate comments.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mac80211/rx.c

index 969be3adda7a1f14f63a1cb2ef4c1c2605ceeb30..75a1e204b9b6bb5e50fd12ff8222470ac7e11e9c 100644 (file)
@@ -327,8 +327,15 @@ ieee80211_rx_h_load_key(struct ieee80211_txrx_data *rx)
         * frames can also use key indizes like GTKs. Hence, if we don't
         * have a PTK/STK we check the key index for a WEP key.
         *
+        * Note that in a regular BSS, multicast frames are sent by the
+        * AP only, associated stations unicast the frame to the AP first
+        * which then multicasts it on their behalf.
+        *
         * There is also a slight problem in IBSS mode: GTKs are negotiated
         * with each station, that is something we don't currently handle.
+        * The spec seems to expect that one negotiates the same key with
+        * every station but there's no such requirement; VLANs could be
+        * possible.
         */
 
        if (!(rx->fc & IEEE80211_FCTL_PROTECTED))