perf tests: Replace assignment with comparison on assert check
authorColin Ian King <colin.king@canonical.com>
Sat, 23 Apr 2016 13:45:54 +0000 (14:45 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 25 Apr 2016 23:24:26 +0000 (20:24 -0300)
The current assert check is checking an assignment, which will always be
true.  Instead, the assert should be checking if scale is equal to 0.122

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1461419154-16918-1-git-send-email-colin.king@canonical.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/event_update.c

index 012eab5d1df115e7cbeb7d8a505a46d0e43f854a..63ecf21750eb0dca6e865cb90a57905df1fb566e 100644 (file)
@@ -30,7 +30,7 @@ static int process_event_scale(struct perf_tool *tool __maybe_unused,
 
        TEST_ASSERT_VAL("wrong id", ev->id == 123);
        TEST_ASSERT_VAL("wrong id", ev->type == PERF_EVENT_UPDATE__SCALE);
-       TEST_ASSERT_VAL("wrong scale", ev_data->scale = 0.123);
+       TEST_ASSERT_VAL("wrong scale", ev_data->scale == 0.123);
        return 0;
 }