ti-st: Fix complete_all() wrong usage

complete_all() should only be called once, doing it twice is a clear bug.

8565adbc8214 ("drivers/misc/ti-st: fix read fw version cmd") added the
additional complete_all() call. Since we call complete_all() when
leaving the function we can drop the complete_all() call inside
true branch of the if statement.

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Pavan Savoy <pavan_savoy@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
index 71b64550b591840ef1712f09f3f93a107d04e2ae..bf0d7708beac59e2723d774ceb4297b2e2700669 100644 (file)
--- a/drivers/misc/ti-st/st_kim.c
+++ b/drivers/misc/ti-st/st_kim.c
@@ -78,7 +78,6 @@ static void validate_firmware_response(struct kim_data_s *kim_gdata)
                memcpy(kim_gdata->resp_buffer,
                                kim_gdata->rx_skb->data,
                                kim_gdata->rx_skb->len);
-               complete_all(&kim_gdata->kim_rcvd);
                kim_gdata->rx_state = ST_W4_PACKET_TYPE;
                kim_gdata->rx_skb = NULL;
                kim_gdata->rx_count = 0;