drm/rockchip: Use .dumb_map_offset and .dumb_destroy defaults
authorNoralf Trønnes <noralf@tronnes.org>
Sun, 23 Jul 2017 19:16:40 +0000 (21:16 +0200)
committerNoralf Trønnes <noralf@tronnes.org>
Sat, 29 Jul 2017 12:00:35 +0000 (14:00 +0200)
This driver can use the drm_driver.dumb_destroy and
drm_driver.dumb_map_offset defaults, so no need to set them.

Cc: Mark Yao <mark.yao@rock-chips.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1500837417-40580-25-git-send-email-noralf@tronnes.org
drivers/gpu/drm/rockchip/rockchip_drm_drv.c
drivers/gpu/drm/rockchip/rockchip_drm_gem.c
drivers/gpu/drm/rockchip/rockchip_drm_gem.h

index 131cb5c86def8cff14b6ba068593a289fc1b8165..848edcf2221a13b7d62336f55b0045681ffa59a0 100644 (file)
@@ -233,8 +233,6 @@ static struct drm_driver rockchip_drm_driver = {
        .gem_vm_ops             = &drm_gem_cma_vm_ops,
        .gem_free_object_unlocked = rockchip_gem_free_object,
        .dumb_create            = rockchip_gem_dumb_create,
-       .dumb_map_offset        = rockchip_gem_dumb_map_offset,
-       .dumb_destroy           = drm_gem_dumb_destroy,
        .prime_handle_to_fd     = drm_gem_prime_handle_to_fd,
        .prime_fd_to_handle     = drm_gem_prime_fd_to_handle,
        .gem_prime_import       = drm_gem_prime_import,
index b74ac717e56a502a647bf3a601c1166e7787ffa2..f74333efe4bbdb32924afddc0c139573147618ca 100644 (file)
@@ -393,32 +393,6 @@ err_handle_create:
        return ERR_PTR(ret);
 }
 
-int rockchip_gem_dumb_map_offset(struct drm_file *file_priv,
-                                struct drm_device *dev, uint32_t handle,
-                                uint64_t *offset)
-{
-       struct drm_gem_object *obj;
-       int ret;
-
-       obj = drm_gem_object_lookup(file_priv, handle);
-       if (!obj) {
-               DRM_ERROR("failed to lookup gem object.\n");
-               return -EINVAL;
-       }
-
-       ret = drm_gem_create_mmap_offset(obj);
-       if (ret)
-               goto out;
-
-       *offset = drm_vma_node_offset_addr(&obj->vma_node);
-       DRM_DEBUG_KMS("offset = 0x%llx\n", *offset);
-
-out:
-       drm_gem_object_unreference_unlocked(obj);
-
-       return 0;
-}
-
 /*
  * rockchip_gem_dumb_create - (struct drm_driver)->dumb_create callback
  * function
index 3f6ea4d18a5c4746f0cd8e7b0f16f49f82612504..f237375582fb668053e2082d8a7311a2e2346aa1 100644 (file)
@@ -57,7 +57,4 @@ void rockchip_gem_free_object(struct drm_gem_object *obj);
 int rockchip_gem_dumb_create(struct drm_file *file_priv,
                             struct drm_device *dev,
                             struct drm_mode_create_dumb *args);
-int rockchip_gem_dumb_map_offset(struct drm_file *file_priv,
-                                struct drm_device *dev, uint32_t handle,
-                                uint64_t *offset);
 #endif /* _ROCKCHIP_DRM_GEM_H */