staging: vc04_services: Remove VCHIQ_DEQUEUE_MESSAGE_T typedef
authorDominic Braun <inf.braun@fau.de>
Fri, 14 Dec 2018 12:04:54 +0000 (13:04 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 13:34:25 +0000 (14:34 +0100)
Typedefing structs is not encouraged in the kernel.

Signed-off-by: Dominic Braun <inf.braun@fau.de>
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h

index 9ba97350052950a3d5956064818545faeca17f75..2db679af38e2e1016af48412bbc6ab65a5134fba 100644 (file)
@@ -1318,7 +1318,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        } break;
 
        case VCHIQ_IOC_DEQUEUE_MESSAGE: {
-               VCHIQ_DEQUEUE_MESSAGE_T args;
+               struct vchiq_dequeue_message args;
                struct user_service *user_service;
                VCHIQ_HEADER_T *header;
 
@@ -1876,7 +1876,7 @@ vchiq_compat_ioctl_dequeue_message(struct file *file,
                                   unsigned int cmd,
                                   unsigned long arg)
 {
-       VCHIQ_DEQUEUE_MESSAGE_T __user *args;
+       struct vchiq_dequeue_message __user *args;
        struct vchiq_dequeue_message32 args32;
 
        args = compat_alloc_user_space(sizeof(*args));
index 89592ae90b8cd8922b4759f0746e0fbf1ab78e85..aaf825f7a0f7f0353c9094c2ffe924322cfa707b 100644 (file)
@@ -76,12 +76,12 @@ struct vchiq_await_completion {
        void **msgbufs;
 };
 
-typedef struct {
+struct vchiq_dequeue_message {
        unsigned int handle;
        int blocking;
        unsigned int bufsize;
        void *buf;
-} VCHIQ_DEQUEUE_MESSAGE_T;
+};
 
 typedef struct {
        unsigned int config_size;
@@ -113,7 +113,7 @@ typedef struct {
 #define VCHIQ_IOC_AWAIT_COMPLETION \
        _IOWR(VCHIQ_IOC_MAGIC, 7, struct vchiq_await_completion)
 #define VCHIQ_IOC_DEQUEUE_MESSAGE \
-       _IOWR(VCHIQ_IOC_MAGIC, 8, VCHIQ_DEQUEUE_MESSAGE_T)
+       _IOWR(VCHIQ_IOC_MAGIC, 8, struct vchiq_dequeue_message)
 #define VCHIQ_IOC_GET_CLIENT_ID        _IO(VCHIQ_IOC_MAGIC,   9)
 #define VCHIQ_IOC_GET_CONFIG \
        _IOWR(VCHIQ_IOC_MAGIC, 10, VCHIQ_GET_CONFIG_T)